From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Thu, 10 Nov 2011 18:44:18 +0100
Subject: [U-Boot] [PATCH 06/20] iMX28: Add GPIO control
In-Reply-To: <201111101210.15600.vapier@gentoo.org>
References: <1320830307-4762-1-git-send-email-marek.vasut@gmail.com>
	<201111101758.17948.marek.vasut@gmail.com>
	<201111101210.15600.vapier@gentoo.org>
Message-ID: <201111101844.18608.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> On Thursday 10 November 2011 11:58:17 Marek Vasut wrote:
> > > On Wednesday 09 November 2011 04:18:13 Marek Vasut wrote:
> > > > +int gpio_request(int gp, const char *label)
> > > 
> > > all of these gpio funcs should be "unsigned gpio"
> > 
> > It's a problem of API then?
> > 
> > include/asm/gpio.h:int gpio_request(int gp, const char *label);
> 
> a patch has been posted already to fix that

Posted, yes ... applied?

> 
> > TBH, I can't imagine gpio number to be lower than zero, but who knows.
> 
> such a value makes no sense.  the incoming number is interpreted by the
> gpio driver, so the starting/ending numbers are completely arbitrary. 
> thus we deal with unsigned only.
> -mike

Definitelly.