From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Fri, 11 Nov 2011 10:18:39 -0500 Subject: [U-Boot] [PATCH 1/3] smsc95xx: Fix MAC address programming In-Reply-To: <4EBD15FC.9070301@grandegger.com> References: <1321009198-20695-1-git-send-email-wg@denx.de> <201111111204.24639.marek.vasut@gmail.com> <4EBD15FC.9070301@grandegger.com> Message-ID: <201111111018.41150.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 11 November 2011 07:33:00 Wolfgang Grandegger wrote: > On 11/11/2011 12:04 PM, Marek Vasut wrote: > >> Commit 79ad54400932d6484178a372fb3b659e3437473b broke the MAC > >> address programming. Fix this by using the method from Linux' > >> smsc95xx_set_mac_address(). > >> > >> --- a/drivers/usb/eth/smsc95xx.c > >> +++ b/drivers/usb/eth/smsc95xx.c > >> > >> - u32 addr_lo, addr_hi; > >> + u32 addr_lo = eth->enetaddr[0] | eth->enetaddr[1] << 8 | > >> + eth->enetaddr[2] << 16 | eth->enetaddr[3] << 24; > >> + u32 addr_hi = eth->enetaddr[4] | eth->enetaddr[5] << 8; > >> > >> int ret; > >> > >> /* set hardware address */ > >> debug("** %s()\n", __func__); > >> > >> - addr_lo = cpu_to_le32(*eth->enetaddr); > >> - addr_hi = cpu_to_le16(*((u16 *)(eth->enetaddr + 4))); > >> + > >> > > > > didn't Mike Frysinger send similar patch yesterday? Also, do you have the > > Ah, I obviously missed that. > > > hardware? If so, that's good, we know you can provide tested fix. > > Well, yes, I know somebody who has smsc95xx hardware ;-). > > > Mike, are you good with using this fix instead or can you two negotiate? > > Let's await Mike's answer (now on CC as well). I need to re-send the > series anyway due to a stupid typo. mine might take a little longer due to wrangling with wolfgang. i'd suggest we go with your patch (although i have feedback on it). -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20111111/8f9764e6/attachment.pgp