From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] smsc95xx: Fix MAC address programming
Date: Fri, 11 Nov 2011 10:20:50 -0500 [thread overview]
Message-ID: <201111111020.51583.vapier@gentoo.org> (raw)
In-Reply-To: <1321009198-20695-2-git-send-email-wg@denx.de>
On Friday 11 November 2011 05:59:56 Wolfgang Grandegger wrote:
> Commit 79ad54400932d6484178a372fb3b659e3437473b broke the MAC
> address programming. Fix this by using the method from Linux'
> smsc95xx_set_mac_address().
>
> --- a/drivers/usb/eth/smsc95xx.c
> +++ b/drivers/usb/eth/smsc95xx.c
>
> - u32 addr_lo, addr_hi;
> + u32 addr_lo = eth->enetaddr[0] | eth->enetaddr[1] << 8 |
> + eth->enetaddr[2] << 16 | eth->enetaddr[3] << 24;
> + u32 addr_hi = eth->enetaddr[4] | eth->enetaddr[5] << 8;
please use:
#include <asm/unaligned.h>
u32 addr_lo = __get_unaligned_le32(ð->enetaddr[0]);
u32 addr_hi = __get_unaligned_le16(ð->enetaddr[4]);
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111111/1228de54/attachment.pgp
next prev parent reply other threads:[~2011-11-11 15:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 10:59 [U-Boot] [PATCH 0/3] smsc95xx: Fix MAC address programming and some minor issues Wolfgang Grandegger
2011-11-11 10:59 ` [U-Boot] [PATCH 1/3] smsc95xx: Fix MAC address programming Wolfgang Grandegger
2011-11-11 11:04 ` Marek Vasut
2011-11-11 12:33 ` Wolfgang Grandegger
2011-11-11 15:18 ` Mike Frysinger
2011-11-14 8:25 ` Wolfgang Grandegger
2011-11-14 16:50 ` Mike Frysinger
2011-11-15 9:25 ` Wolfgang Grandegger
2011-11-11 15:20 ` Mike Frysinger [this message]
2011-11-11 15:22 ` Mike Frysinger
2011-11-11 10:59 ` [U-Boot] [PATCH 2/3] smsc95xx: in smsc95xx_set_multicast write to reg Wolfgang Grandegger
2011-11-11 15:35 ` Simon Glass
2011-11-14 12:18 ` Wolfgang Grandegger
2011-11-14 20:06 ` Simon Glass
2011-11-11 10:59 ` [U-Boot] [PATCH 3/3] smsc95xx: remove an unecessary debug messages Wolfgang Grandegger
2011-11-11 15:26 ` Simon Glass
2011-11-14 8:33 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111111020.51583.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox