public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] smsc95xx: Fix MAC address programming
Date: Fri, 11 Nov 2011 12:04:24 +0100	[thread overview]
Message-ID: <201111111204.24639.marek.vasut@gmail.com> (raw)
In-Reply-To: <1321009198-20695-2-git-send-email-wg@denx.de>

> Commit 79ad54400932d6484178a372fb3b659e3437473b broke the MAC
> address programming. Fix this by using the method from Linux'
> smsc95xx_set_mac_address().
> 
> Signed-off-by: Wolfgang Grandegger <wg@denx.de>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  drivers/usb/eth/smsc95xx.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
> index 7ee4f87..eb529f1 100644
> --- a/drivers/usb/eth/smsc95xx.c
> +++ b/drivers/usb/eth/smsc95xx.c
> @@ -372,13 +372,14 @@ static int smsc95xx_init_mac_address(struct
> eth_device *eth, static int smsc95xx_write_hwaddr(struct eth_device *eth)
>  {
>  	struct ueth_data *dev = (struct ueth_data *)eth->priv;
> -	u32 addr_lo, addr_hi;
> +	u32 addr_lo = eth->enetaddr[0] | eth->enetaddr[1] << 8 |
> +		eth->enetaddr[2] << 16 | eth->enetaddr[3] << 24;
> +	u32 addr_hi = eth->enetaddr[4] | eth->enetaddr[5] << 8;
>  	int ret;
> 
>  	/* set hardware address */
>  	debug("** %s()\n", __func__);
> -	addr_lo = cpu_to_le32(*eth->enetaddr);
> -	addr_hi = cpu_to_le16(*((u16 *)(eth->enetaddr + 4)));
> +
>  	ret = smsc95xx_write_reg(dev, ADDRL, addr_lo);
>  	if (ret < 0) {
>  		debug("Failed to write ADDRL: %d\n", ret);

Hey,

didn't Mike Frysinger send similar patch yesterday? Also, do you have the 
hardware? If so, that's good, we know you can provide tested fix.

Mike, are you good with using this fix instead or can you two negotiate?

M

  reply	other threads:[~2011-11-11 11:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-11 10:59 [U-Boot] [PATCH 0/3] smsc95xx: Fix MAC address programming and some minor issues Wolfgang Grandegger
2011-11-11 10:59 ` [U-Boot] [PATCH 1/3] smsc95xx: Fix MAC address programming Wolfgang Grandegger
2011-11-11 11:04   ` Marek Vasut [this message]
2011-11-11 12:33     ` Wolfgang Grandegger
2011-11-11 15:18       ` Mike Frysinger
2011-11-14  8:25         ` Wolfgang Grandegger
2011-11-14 16:50           ` Mike Frysinger
2011-11-15  9:25             ` Wolfgang Grandegger
2011-11-11 15:20   ` Mike Frysinger
2011-11-11 15:22   ` Mike Frysinger
2011-11-11 10:59 ` [U-Boot] [PATCH 2/3] smsc95xx: in smsc95xx_set_multicast write to reg Wolfgang Grandegger
2011-11-11 15:35   ` Simon Glass
2011-11-14 12:18     ` Wolfgang Grandegger
2011-11-14 20:06       ` Simon Glass
2011-11-11 10:59 ` [U-Boot] [PATCH 3/3] smsc95xx: remove an unecessary debug messages Wolfgang Grandegger
2011-11-11 15:26   ` Simon Glass
2011-11-14  8:33     ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111111204.24639.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox