From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Wed, 16 Nov 2011 03:26:46 +0100
Subject: [U-Boot] [PATCH 02/19] usbdev.c: Fix GCC 4.6 build warnings
In-Reply-To: <201111151801.16723.vapier@gentoo.org>
References: <1321380112-6210-1-git-send-email-sr@denx.de>
	<201111151801.16723.vapier@gentoo.org>
Message-ID: <201111160326.46270.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> On Tuesday 15 November 2011 13:01:52 Stefan Roese wrote:
> > --- a/arch/powerpc/cpu/ppc4xx/usbdev.c
> > +++ b/arch/powerpc/cpu/ppc4xx/usbdev.c
> > 
> > -	int temp, temp1;
> > ...
> > 
> >  		/*copy packet */
> >  		setup_packet_pt[0] = *(unsigned int *)USB2D0_FIFO_0;
> >  		setup_packet_pt[1] = *(unsigned int *)USB2D0_FIFO_0;
> > 
> > -		temp = *(unsigned int *)USB2D0_FIFO_0;
> > -		temp1 = *(unsigned int *)USB2D0_FIFO_0;
> 
> this seems to be treading into possible ugly volatile area ... perhaps best
> if this was acked/tested by someone with actual hardware first ...
> -mike

My words definitelly ... maybe replace with in_be32() ? It seems very 
suspicious, as if there was a reason for this access. Like you need to do more 
accesses to the fifo to clean up some trailing crud.

M