public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 15/19] cmd_dasa_sim.c: Fix GCC 4.6 build warnings
@ 2011-11-15 18:03 Stefan Roese
  2011-11-16 20:17 ` Wolfgang Denk
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Roese @ 2011-11-15 18:03 UTC (permalink / raw)
  To: u-boot

Fix:
cmd_dasa_sim.c: In function 'updatePci9054':
cmd_dasa_sim.c:135:6: warning: variable 'val' set but not used [-Wunused-but-set-variable]
cmd_dasa_sim.c: In function 'clearPci9054':
cmd_dasa_sim.c:189:6: warning: variable 'val' set but not used [-Wunused-but-set-variable]

Signed-off-by: Stefan Roese <sr@denx.de>
---
 board/esd/dasa_sim/cmd_dasa_sim.c |   52 +++++++++++++++++--------------------
 1 files changed, 24 insertions(+), 28 deletions(-)

diff --git a/board/esd/dasa_sim/cmd_dasa_sim.c b/board/esd/dasa_sim/cmd_dasa_sim.c
index 4946538..0014808 100644
--- a/board/esd/dasa_sim/cmd_dasa_sim.c
+++ b/board/esd/dasa_sim/cmd_dasa_sim.c
@@ -132,8 +132,6 @@ static void showPci9054 (void)
 
 static void updatePci9054 (void)
 {
-	int val;
-
 	/*
 	 * Set EEPROM write-protect register to 0
 	 */
@@ -141,44 +139,44 @@ static void updatePci9054 (void)
 		  in_be32 ((void *)(pci9054_iobase + 0x0c)) & 0xffff00ff);
 
 	/* Long Serial EEPROM Load Registers... */
-	val = PciEepromWriteLongVPD (0x00, 0x905410b5);
-	val = PciEepromWriteLongVPD (0x04, 0x09800001);	/* other input controller */
-	val = PciEepromWriteLongVPD (0x08, 0x28140100);
+	PciEepromWriteLongVPD (0x00, 0x905410b5);
+	PciEepromWriteLongVPD (0x04, 0x09800001);	/* other input controller */
+	PciEepromWriteLongVPD (0x08, 0x28140100);
 
-	val = PciEepromWriteLongVPD (0x0c, 0x00000000);	/* MBOX0... */
-	val = PciEepromWriteLongVPD (0x10, 0x00000000);
+	PciEepromWriteLongVPD (0x0c, 0x00000000);	/* MBOX0... */
+	PciEepromWriteLongVPD (0x10, 0x00000000);
 
 	/* las0: fpga access (0x0000.0000 ... 0x0003.ffff) */
-	val = PciEepromWriteLongVPD (0x14, 0xfffc0000);	/* LAS0RR... */
-	val = PciEepromWriteLongVPD (0x18, 0x00000001);	/* LAS0BA */
+	PciEepromWriteLongVPD (0x14, 0xfffc0000);	/* LAS0RR... */
+	PciEepromWriteLongVPD (0x18, 0x00000001);	/* LAS0BA */
 
-	val = PciEepromWriteLongVPD (0x1c, 0x00200000);	/* MARBR... */
-	val = PciEepromWriteLongVPD (0x20, 0x00300500);	/* LMISC/BIGEND */
+	PciEepromWriteLongVPD (0x1c, 0x00200000);	/* MARBR... */
+	PciEepromWriteLongVPD (0x20, 0x00300500);	/* LMISC/BIGEND */
 
-	val = PciEepromWriteLongVPD (0x24, 0x00000000);	/* EROMRR... */
-	val = PciEepromWriteLongVPD (0x28, 0x00000000);	/* EROMBA */
+	PciEepromWriteLongVPD (0x24, 0x00000000);	/* EROMRR... */
+	PciEepromWriteLongVPD (0x28, 0x00000000);	/* EROMBA */
 
-	val = PciEepromWriteLongVPD (0x2c, 0x43030000);	/* LBRD0... */
+	PciEepromWriteLongVPD (0x2c, 0x43030000);	/* LBRD0... */
 
-	val = PciEepromWriteLongVPD (0x30, 0x00000000);	/* DMRR... */
-	val = PciEepromWriteLongVPD (0x34, 0x00000000);
-	val = PciEepromWriteLongVPD (0x38, 0x00000000);
+	PciEepromWriteLongVPD (0x30, 0x00000000);	/* DMRR... */
+	PciEepromWriteLongVPD (0x34, 0x00000000);
+	PciEepromWriteLongVPD (0x38, 0x00000000);
 
-	val = PciEepromWriteLongVPD (0x3c, 0x00000000);	/* DMPBAM... */
-	val = PciEepromWriteLongVPD (0x40, 0x00000000);
+	PciEepromWriteLongVPD (0x3c, 0x00000000);	/* DMPBAM... */
+	PciEepromWriteLongVPD (0x40, 0x00000000);
 
 	/* Extra Long Serial EEPROM Load Registers... */
-	val = PciEepromWriteLongVPD (0x44, 0x010212fe);	/* PCISID... */
+	PciEepromWriteLongVPD (0x44, 0x010212fe);	/* PCISID... */
 
 	/* las1: 505-sram access (0x0004.0000 ... 0x001f.ffff) */
 	/* Offset to LAS1: Group 1: 0x00040000                 */
 	/*                 Group 2: 0x00080000                 */
 	/*                 Group 3: 0x000c0000                 */
-	val = PciEepromWriteLongVPD (0x48, 0xffe00000);	/* LAS1RR */
-	val = PciEepromWriteLongVPD (0x4c, 0x00040001);	/* LAS1BA */
-	val = PciEepromWriteLongVPD (0x50, 0x00000208);	/* LBRD1 */ /* so wars bisher */
+	PciEepromWriteLongVPD (0x48, 0xffe00000);	/* LAS1RR */
+	PciEepromWriteLongVPD (0x4c, 0x00040001);	/* LAS1BA */
+	PciEepromWriteLongVPD (0x50, 0x00000208);	/* LBRD1 */ /* so wars bisher */
 
-	val = PciEepromWriteLongVPD (0x54, 0x00004c06);	/* HotSwap... */
+	PciEepromWriteLongVPD (0x54, 0x00004c06);	/* HotSwap... */
 
 	printf ("Finished writing defaults into PLX PCI9054 EEPROM!\n");
 }
@@ -186,8 +184,6 @@ static void updatePci9054 (void)
 
 static void clearPci9054 (void)
 {
-	int val;
-
 	/*
 	 * Set EEPROM write-protect register to 0
 	 */
@@ -195,8 +191,8 @@ static void clearPci9054 (void)
 		  in_be32 ((void *)(pci9054_iobase + 0x0c)) & 0xffff00ff);
 
 	/* Long Serial EEPROM Load Registers... */
-	val = PciEepromWriteLongVPD (0x00, 0xffffffff);
-	val = PciEepromWriteLongVPD (0x04, 0xffffffff);	/* other input controller */
+	PciEepromWriteLongVPD (0x00, 0xffffffff);
+	PciEepromWriteLongVPD (0x04, 0xffffffff);	/* other input controller */
 
 	printf ("Finished clearing PLX PCI9054 EEPROM!\n");
 }
-- 
1.7.7.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH 15/19] cmd_dasa_sim.c: Fix GCC 4.6 build warnings
  2011-11-15 18:03 [U-Boot] [PATCH 15/19] cmd_dasa_sim.c: Fix GCC 4.6 build warnings Stefan Roese
@ 2011-11-16 20:17 ` Wolfgang Denk
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2011-11-16 20:17 UTC (permalink / raw)
  To: u-boot

Dear Stefan Roese,

In message <1321380200-6833-1-git-send-email-sr@denx.de> you wrote:
> Fix:
> cmd_dasa_sim.c: In function 'updatePci9054':
> cmd_dasa_sim.c:135:6: warning: variable 'val' set but not used [-Wunused-but-set-variable]
> cmd_dasa_sim.c: In function 'clearPci9054':
> cmd_dasa_sim.c:189:6: warning: variable 'val' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  board/esd/dasa_sim/cmd_dasa_sim.c |   52 +++++++++++++++++--------------------
>  1 files changed, 24 insertions(+), 28 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quantum particles: The dreams that stuff is made of.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-16 20:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-15 18:03 [U-Boot] [PATCH 15/19] cmd_dasa_sim.c: Fix GCC 4.6 build warnings Stefan Roese
2011-11-16 20:17 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox