From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] checkpatch compliance
Date: Thu, 17 Nov 2011 16:33:27 -0500 [thread overview]
Message-ID: <201111171633.29471.vapier@gentoo.org> (raw)
In-Reply-To: <4EC56A2E.2000708@keymile.com>
On Thursday 17 November 2011 15:10:22 Gerlando Falauto wrote:
> On 10/08/2011 12:28 AM, Joe Hershberger wrote:
> > Hi Wolfgang,
> >
> > I'm attempting to make the files I touched in several recent
> > patch-series chechkpatch.pl compliant.
> >
> > I've hit several cases which fail and probably shouldn't. For each of
> > these cases, should the warning / error just be ignored or reported to
> > checkpatch maintainers or altered some other way?
>
> What is wrong with something like:
>
> ERROR: do not initialise statics to 0 or NULL
> #35: FILE: serial.c:32:
> +static struct serial_device *serial_devices = NULL;
>
> ERROR: do not initialise statics to 0 or NULL
> #36: FILE: serial.c:33:
> +static struct serial_device *serial_current = NULL;
newer gcc is smart enough to put these into .bss. i think older ones were not
and put these into .data. in either case, the initialization is redundant (by
virtue of the "static"), so i'd just drop the "= NULL".
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111117/872b3a32/attachment.pgp>
prev parent reply other threads:[~2011-11-17 21:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 22:28 [U-Boot] checkpatch compliance Joe Hershberger
2011-10-09 19:22 ` Wolfgang Denk
2011-10-12 1:41 ` [U-Boot] [PATCH] tools: checkpatch.pl from Linux added to tools Joe Hershberger
2011-10-13 2:54 ` Xiangfu Liu
2011-10-13 3:27 ` Mike Frysinger
2011-10-13 17:25 ` Joe Hershberger
2011-10-13 18:20 ` Mike Frysinger
2011-10-13 18:30 ` Joe Hershberger
2011-10-13 19:01 ` Mike Frysinger
2011-10-18 20:06 ` [U-Boot] [PATCH v2] " Joe Hershberger
2011-10-19 18:28 ` Joe Hershberger
2011-11-17 13:28 ` Wolfgang Denk
2011-10-12 1:42 ` [U-Boot] checkpatch compliance Joe Hershberger
2011-10-12 3:59 ` Mike Frysinger
2011-10-12 7:36 ` Wolfgang Denk
2011-10-12 17:57 ` Mike Frysinger
2011-10-12 18:41 ` Wolfgang Denk
2011-10-12 19:24 ` Mike Frysinger
2011-10-13 23:03 ` [U-Boot] [PATCH 1/2] common: cosmetic: CONFIG_ROOTPATH " Joe Hershberger
2011-10-13 22:34 ` Mike Frysinger
2011-10-21 23:21 ` Wolfgang Denk
2011-10-13 23:03 ` [U-Boot] [PATCH 2/2] common: cosmetic: CONFIG_BOOTFILE " Joe Hershberger
2011-10-13 22:34 ` Mike Frysinger
2011-10-13 22:41 ` Joe Hershberger
2011-10-21 23:21 ` Wolfgang Denk
2011-10-13 0:56 ` [U-Boot] " Joe Hershberger
2011-10-13 1:03 ` Mike Frysinger
2011-10-13 17:14 ` Joe Hershberger
2011-10-13 18:19 ` Mike Frysinger
2011-10-13 20:36 ` Wolfgang Denk
2011-11-17 20:10 ` Gerlando Falauto
2011-11-17 20:54 ` Wolfgang Denk
2011-11-18 7:25 ` Gerlando Falauto
2011-11-17 21:33 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111171633.29471.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox