From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Fix warnings in arch/arm/cpu/arm920t/s3c24x0/usb_ohci.c
Date: Fri, 18 Nov 2011 03:35:52 +0100 [thread overview]
Message-ID: <201111180335.52597.marek.vasut@gmail.com> (raw)
In-Reply-To: <201111161637.43731.vapier@gentoo.org>
> On Wednesday 16 November 2011 16:16:49 Simon Glass wrote:
> > On Wed, Nov 16, 2011 at 8:03 AM, Mike Frysinger wrote:
> > > On Tuesday 15 November 2011 23:17:06 Simon Glass wrote:
> > >> --- a/arch/arm/cpu/arm920t/s3c24x0/usb_ohci.c
> > >> +++ b/arch/arm/cpu/arm920t/s3c24x0/usb_ohci.c
> > >>
> > >> - __u32 datab[4];
> > >> - __u8 *data_buf = (__u8 *) datab;
> > >> + union {
> > >> + __u32 word[4];
> > >> + __u16 hword[8];
> > >> + __u8 byte[16];
> > >> + } datab;
> > >> + __u8 *data_buf = datab.byte;
> > >
> > > i thought someone posted this fix to the list before. but maybe it was
> > > for a different controller. perhaps this code has been copied/pasted
> > > all over ... -mike
> >
> > Yes I found Marek's patch to another file with the same name, and much
> > of the same code :-( But I don't think we currently have a patch for
> > this file. It issues warnings in about 10 ARM builds from memory.
>
> np. i know much of the u-boot arm tree (like Linux) has crappy cross-SoC
> integration.
>
> Acked-by: Mike Frysinger <vapier@gentoo.org>
> -mike
Well it kinda looks like this OHCI is copy of the drivers/usb/host/ohci-hcd.c ?
M
next prev parent reply other threads:[~2011-11-18 2:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 4:17 [U-Boot] [PATCH 1/2] Fix warnings in arch/arm/cpu/arm920t/s3c24x0/usb_ohci.c Simon Glass
2011-11-16 4:17 ` [U-Boot] [PATCH 2/2] Fix warnings in yaffs Simon Glass
2011-11-16 20:39 ` Wolfgang Denk
2011-11-16 21:38 ` Mike Frysinger
2011-11-16 21:50 ` Simon Glass
2011-11-16 16:03 ` [U-Boot] [PATCH 1/2] Fix warnings in arch/arm/cpu/arm920t/s3c24x0/usb_ohci.c Mike Frysinger
2011-11-16 21:16 ` Simon Glass
2011-11-16 21:37 ` Mike Frysinger
2011-11-18 2:35 ` Marek Vasut [this message]
2011-11-18 22:47 ` Simon Glass
2011-12-02 16:33 ` Simon Glass
2011-12-02 16:53 ` Stefano Babic
2011-12-02 17:02 ` Simon Glass
2011-12-09 9:33 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111180335.52597.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox