[U-Boot] [PATCH] tegra2: Fix out-of-tree build for Ventana.

[U-Boot] [PATCH] tegra2: Fix out-of-tree build for Ventana.

[Thierry Reding]

Since Ventana is derived from Seaboard and requires seaboard.c to build,
make sure board/nvidia/seaboard is created in the build tree.

Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
 board/nvidia/ventana/Makefile |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/board/nvidia/ventana/Makefile b/board/nvidia/ventana/Makefile
index 9e5a87f..d5140c8 100644
--- a/board/nvidia/ventana/Makefile
+++ b/board/nvidia/ventana/Makefile
@@ -25,6 +25,7 @@
 include $(TOPDIR)/config.mk
 
 ifneq ($(OBJTREE),$(SRCTREE))
+$(shell mkdir -p $(obj)../seaboard)
 $(shell mkdir -p $(obj)../common)
 endif
 
-- 
1.7.7.3

[U-Boot] [PATCH] tegra2: Fix out-of-tree build for Ventana.

[Stephen Warren]

Thierry Reding wrote at Thursday, November 17, 2011 2:48 AM:
> Since Ventana is derived from Seaboard and requires seaboard.c to build,
> make sure board/nvidia/seaboard is created in the build tree.
> 
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>

Acked-by: Stephen Warren <swarren@nvidia.com>
Tested-by: Stephen Warren <swarren@nvidia.com>

-- 
nvpublic

[U-Boot] [PATCH] tegra2: Fix out-of-tree build for Ventana.

[Mike Frysinger]

On Thursday 17 November 2011 04:48:22 Thierry Reding wrote:
> Since Ventana is derived from Seaboard and requires seaboard.c to build,
> make sure board/nvidia/seaboard is created in the build tree.
> 
> --- a/board/nvidia/ventana/Makefile
> +++ b/board/nvidia/ventana/Makefile
> 
>  ifneq ($(OBJTREE),$(SRCTREE))
> +$(shell mkdir -p $(obj)../seaboard)
>  $(shell mkdir -p $(obj)../common)
>  endif

mkdir takes multiple paths.  thus my proposal:
-$(shell mkdir -p $(obj)../common)
+$(shell mkdir -p $(obj)../common $(obj)../seaboard)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111117/c3ab2da8/attachment.pgp>

[U-Boot] [PATCH] tegra2: Fix out-of-tree build for Ventana.

[Thierry Reding]

* Mike Frysinger wrote:
> On Thursday 17 November 2011 04:48:22 Thierry Reding wrote:
> > Since Ventana is derived from Seaboard and requires seaboard.c to build,
> > make sure board/nvidia/seaboard is created in the build tree.
> > 
> > --- a/board/nvidia/ventana/Makefile
> > +++ b/board/nvidia/ventana/Makefile
> > 
> >  ifneq ($(OBJTREE),$(SRCTREE))
> > +$(shell mkdir -p $(obj)../seaboard)
> >  $(shell mkdir -p $(obj)../common)
> >  endif
> 
> mkdir takes multiple paths.  thus my proposal:
> -$(shell mkdir -p $(obj)../common)
> +$(shell mkdir -p $(obj)../common $(obj)../seaboard)
> -mike

Heh, right. =)

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111118/9bac01c9/attachment.pgp>

[U-Boot] [PATCH] tegra2: Fix out-of-tree build for Ventana.

[Wolfgang Denk]

Dear Thierry Reding,

In message <1321523302-4761-1-git-send-email-thierry.reding@avionic-design.de> you wrote:
> Since Ventana is derived from Seaboard and requires seaboard.c to build,
> make sure board/nvidia/seaboard is created in the build tree.
> 
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> ---
>  board/nvidia/ventana/Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Verified that this indeed fixes the Ventana OOT build issues.  Thanks.

Tested-by: Wolfgang Denk <wd@denx.de>

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The only person who always got his work done by Friday
                                                 was Robinson Crusoe.

[U-Boot] [PATCH] tegra2: Fix out-of-tree build for Ventana.

[Wolfgang Denk]

Dear Thierry Reding,

In message <1321523302-4761-1-git-send-email-thierry.reding@avionic-design.de> you wrote:
> Since Ventana is derived from Seaboard and requires seaboard.c to build,
> make sure board/nvidia/seaboard is created in the build tree.
> 
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> ---
>  board/nvidia/ventana/Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have a very small mind and must live with it.    -- Edsger Dijkstra

[U-Boot] [PATCH] tegra2: Fix out-of-tree build for Ventana.

[Thierry Reding]

* Wolfgang Denk wrote:
> Dear Thierry Reding,
> 
> In message <1321523302-4761-1-git-send-email-thierry.reding@avionic-design.de> you wrote:
> > Since Ventana is derived from Seaboard and requires seaboard.c to build,
> > make sure board/nvidia/seaboard is created in the build tree.
> > 
> > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> > ---
> >  board/nvidia/ventana/Makefile |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> Applied, thanks.

I actually have an updated version applied locally with the change proposed
by Mike, but I completely forgot to send it to the list.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111222/cb1a2bd9/attachment.pgp>

[U-Boot] [PATCH] tegra2: Fix out-of-tree build for Ventana.

[Wolfgang Denk]

Dear Thierry Reding,

In message <20111222090337.GA844@avionic-0098.mockup.avionic-design.de> you wrote:
> 
> I actually have an updated version applied locally with the change proposed
> by Mike, but I completely forgot to send it to the list.

Can you then please submit an incremental patch (against current
master)?  TIA...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It usually takes more than three weeks to prepare  a  good  impromptu
speech.                                                  - Mark Twain

[U-Boot] [PATCH] tegra2: Optimize out-of-tree build for Ventana.

[Thierry Reding]

As proposed by Mike Frysinger, mkdir can take more than one argument.
Instead of spawning two processes, create both the common and seaboard
directories in one go.

Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
I realize how trivial this is, and I feel a little embarrassed.

 board/nvidia/ventana/Makefile |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/board/nvidia/ventana/Makefile b/board/nvidia/ventana/Makefile
index d5140c8..c7e9bba 100644
--- a/board/nvidia/ventana/Makefile
+++ b/board/nvidia/ventana/Makefile
@@ -25,8 +25,7 @@
 include $(TOPDIR)/config.mk
 
 ifneq ($(OBJTREE),$(SRCTREE))
-$(shell mkdir -p $(obj)../seaboard)
-$(shell mkdir -p $(obj)../common)
+$(shell mkdir -p $(obj)../common $(obj)../seaboard)
 endif
 
 LIB	= $(obj)lib$(BOARD).o
-- 
1.7.8