public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] Makefile: Add the missing dependency for spl target
@ 2011-11-05  7:43 Aneesh V
  2011-11-10 16:06 ` Aneesh V
  2011-11-18 16:16 ` Stefan Roese
  0 siblings, 2 replies; 4+ messages in thread
From: Aneesh V @ 2011-11-05  7:43 UTC (permalink / raw)
  To: u-boot

Wolfgang's patch for build time improvement is bringing
out issues due to missing dependencies in the top-level
Makefile. I get errors such as the below while building
with many threads.

make[1]: /home/a0393566local/u-boot-denx/tools/mkimage: Command not found

This also allows one to do:
$ make spl/u-boot-spl.bin
if you want to build only spl

Cc: Wolfgang Denk <wd@denx.de>
Signed-off-by: Aneesh V <aneesh@ti.com>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index 82de62b..7ae8b22 100644
--- a/Makefile
+++ b/Makefile
@@ -481,7 +481,7 @@ mmc_spl:	$(TIMESTAMP_FILE) $(VERSION_FILE) depend
 
 $(obj)mmc_spl/u-boot-mmc-spl.bin:	mmc_spl
 
-$(obj)spl/u-boot-spl.bin:		depend
+$(obj)spl/u-boot-spl.bin:	$(SUBDIR_TOOLS) depend
 		$(MAKE) -C spl all
 
 updater:
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] Makefile: Add the missing dependency for spl target
  2011-11-05  7:43 [U-Boot] [PATCH] Makefile: Add the missing dependency for spl target Aneesh V
@ 2011-11-10 16:06 ` Aneesh V
  2011-11-18  8:25   ` Aneesh V
  2011-11-18 16:16 ` Stefan Roese
  1 sibling, 1 reply; 4+ messages in thread
From: Aneesh V @ 2011-11-10 16:06 UTC (permalink / raw)
  To: u-boot

Hi Wolfgang,

On Saturday 05 November 2011 01:13 PM, Aneesh V wrote:
> Wolfgang's patch for build time improvement is bringing
> out issues due to missing dependencies in the top-level
> Makefile. I get errors such as the below while building
> with many threads.
>
> make[1]: /home/a0393566local/u-boot-denx/tools/mkimage: Command not found

Now that your build time improvement patch is up-stream omap and any
other platform that uses any of the tools during SPL build may face
occasional failures. Can you pull this one if my change looks ok?

>
> This also allows one to do:
> $ make spl/u-boot-spl.bin
> if you want to build only spl
>
> Cc: Wolfgang Denk<wd@denx.de>
> Signed-off-by: Aneesh V<aneesh@ti.com>
> ---
>   Makefile |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 82de62b..7ae8b22 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -481,7 +481,7 @@ mmc_spl:	$(TIMESTAMP_FILE) $(VERSION_FILE) depend
>
>   $(obj)mmc_spl/u-boot-mmc-spl.bin:	mmc_spl
>
> -$(obj)spl/u-boot-spl.bin:		depend
> +$(obj)spl/u-boot-spl.bin:	$(SUBDIR_TOOLS) depend
>   		$(MAKE) -C spl all
>
>   updater:

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] Makefile: Add the missing dependency for spl target
  2011-11-10 16:06 ` Aneesh V
@ 2011-11-18  8:25   ` Aneesh V
  0 siblings, 0 replies; 4+ messages in thread
From: Aneesh V @ 2011-11-18  8:25 UTC (permalink / raw)
  To: u-boot

Dear Wolfgang,

On Thursday 10 November 2011 09:36 PM, Aneesh V wrote:
> Hi Wolfgang,
>
> On Saturday 05 November 2011 01:13 PM, Aneesh V wrote:
>> Wolfgang's patch for build time improvement is bringing
>> out issues due to missing dependencies in the top-level
>> Makefile. I get errors such as the below while building
>> with many threads.
>>
>> make[1]: /home/a0393566local/u-boot-denx/tools/mkimage: Command not found
>
> Now that your build time improvement patch is up-stream omap and any
> other platform that uses any of the tools during SPL build may face
> occasional failures. Can you pull this one if my change looks ok?

Gentle reminder. If you don't have any objections to this one could you
consider pulling it. It avoids a build break.

br,
Aneesh

>
>>
>> This also allows one to do:
>> $ make spl/u-boot-spl.bin
>> if you want to build only spl
>>
>> Cc: Wolfgang Denk<wd@denx.de>
>> Signed-off-by: Aneesh V<aneesh@ti.com>
>> ---
>> Makefile | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 82de62b..7ae8b22 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -481,7 +481,7 @@ mmc_spl: $(TIMESTAMP_FILE) $(VERSION_FILE) depend
>>
>> $(obj)mmc_spl/u-boot-mmc-spl.bin: mmc_spl
>>
>> -$(obj)spl/u-boot-spl.bin: depend
>> +$(obj)spl/u-boot-spl.bin: $(SUBDIR_TOOLS) depend
>> $(MAKE) -C spl all
>>
>> updater:
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] Makefile: Add the missing dependency for spl target
  2011-11-05  7:43 [U-Boot] [PATCH] Makefile: Add the missing dependency for spl target Aneesh V
  2011-11-10 16:06 ` Aneesh V
@ 2011-11-18 16:16 ` Stefan Roese
  1 sibling, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2011-11-18 16:16 UTC (permalink / raw)
  To: u-boot

On Saturday 05 November 2011 08:43:33 Aneesh V wrote:
> Wolfgang's patch for build time improvement is bringing
> out issues due to missing dependencies in the top-level
> Makefile. I get errors such as the below while building
> with many threads.
> 
> make[1]: /home/a0393566local/u-boot-denx/tools/mkimage: Command not found
> 
> This also allows one to do:
> $ make spl/u-boot-spl.bin
> if you want to build only spl

Applied to u-boot-staging sr at denx.de. Thanks.
 
Best regards,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-11-18 16:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-05  7:43 [U-Boot] [PATCH] Makefile: Add the missing dependency for spl target Aneesh V
2011-11-10 16:06 ` Aneesh V
2011-11-18  8:25   ` Aneesh V
2011-11-18 16:16 ` Stefan Roese

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox