From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] Allow arch directory to contain .lds without requiring Makefile
Date: Sun, 20 Nov 2011 00:23:08 -0500 [thread overview]
Message-ID: <201111200023.09358.vapier@gentoo.org> (raw)
In-Reply-To: <201111200507.08697.marek.vasut@gmail.com>
On Saturday 19 November 2011 23:07:08 Marek Vasut wrote:
> > LDSCRIPT := $(TOPDIR)/$(CPUDIR)/u-boot.lds
> > endif
> > ifeq ($(wildcard $(LDSCRIPT)),)
> > + LDSCRIPT := $(TOPDIR)/arch/$(ARCH)/cpu/u-boot.lds
> > + # We don't expect a Makefile here
> > + LDSCRIPT_MAKEFILE_DIR =
> > + endif
> > + ifeq ($(wildcard $(LDSCRIPT)),)
>
> Do I see the same ifeq... twice in here ? I understand what you do here,
> but it'd be good to add a comment please.
in the larger context, it makes sense
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111120/fed3af77/attachment.pgp>
next prev parent reply other threads:[~2011-11-20 5:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 21:47 [U-Boot] [PATCH 0/6] Tidy up ARM link scripts Simon Glass
2011-11-11 21:47 ` [U-Boot] [PATCH 1/6] Allow arch directory to contain .lds without requiring Makefile Simon Glass
2011-11-20 4:07 ` Marek Vasut
2011-11-20 4:54 ` Simon Glass
2011-11-20 5:23 ` Mike Frysinger [this message]
2011-11-11 21:47 ` [U-Boot] [PATCH 2/6] arm: Remove jornada link script Simon Glass
2011-11-17 18:10 ` Marek Vasut
2011-11-19 10:41 ` Kristoffer Ericson
2011-11-19 19:27 ` Marek Vasut
2011-11-19 20:43 ` Simon Glass
2011-11-11 21:47 ` [U-Boot] [PATCH 3/6] arm: Remove unneeded setting of LDCSRIPT Simon Glass
2011-11-11 21:47 ` [U-Boot] [PATCH 4/6] Define CPUDIR for the .lds link script Simon Glass
2011-11-12 3:59 ` Simon Glass
2011-11-11 21:47 ` [U-Boot] [PATCH 5/6] arm: add a common " Simon Glass
2011-11-11 21:47 ` [U-Boot] [PATCH 6/6] arm: Use common .lds file where possible Simon Glass
2011-11-20 4:04 ` [U-Boot] [PATCH 0/6] Tidy up ARM link scripts Marek Vasut
2011-11-20 4:49 ` Simon Glass
2011-11-20 4:56 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111200023.09358.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox