From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Mon, 21 Nov 2011 21:53:45 +0100
Subject: [U-Boot] [PATCH 1/2] efikamx: Configure the pins as GPIOs prior
	to using gpio_get_value.
In-Reply-To: <201111211514.24887.vapier@gentoo.org>
References: <1321884585-12501-1-git-send-email-fabio.estevam@freescale.com>
	<201111212029.50258.marek.vasut@gmail.com>
	<201111211514.24887.vapier@gentoo.org>
Message-ID: <201111212153.45505.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> On Monday 21 November 2011 14:29:50 Marek Vasut wrote:
> > > On Monday 21 November 2011 09:20:49 Marek Vasut wrote:
> > > > > Configure the pins as GPIOs prior to using gpio_get_value
> > > > > 
> > > > > +	else {
> > > > > +		mxc_request_iomux(MX51_PIN_GPIO1_8, IOMUX_CONFIG_ALT0);
> > > > > 
> > > > >  		*absent = 
gpio_get_value(IOMUX_TO_GPIO(MX51_PIN_GPIO1_8));
> > > > > 
> > > > > -
> > > > > +	}
> > > > 
> > > > NAK. There should be some common function for setting up iomux of
> > > > those pins. You souldn't set it in repeatedly called functions.
> > > 
> > > that's what gpio_request() is for
> > 
> > I mean in efika.c ... there should be a common place for these iomux
> > configurations being done. This is unrelated to gpio ...
> 
> not really ... imo, if someone does gpio_request(PIN), the gpio core should
> take care of putting it into GPIO mode.  people shouldn't have to
> pinmux_request(PIN, GPIO_MODE) before doing gpio_request(PIN).

Of course ... considering there's always one correct setting for the pin to be 
in GPIO mode, which I suspect might not be completely true today anymore.