[U-Boot] [PATCH 3/9] openrisc: Add cpu files

Mike Frysinger
2011-11-22T20:54:03Z

On Monday 21 November 2011 23:46:41 Marek Vasut wrote:
> > On Mon, Nov 21, 2011 at 11:50:17PM +0100, Marek Vasut wrote:
> > > > + l.addi r3,r3,4
> > > > + l.sfltu r4,r5
> > > > + l.bf .L_reloc
> > > > + l.addi r4,r4,4 /* delay slot */
> > >
> > > The formating here doesn't seem right?
> >
> > The extra space there is to denote that the instruction is
> > in a delay slot.
> > I think it brings more readability to the code, but if it
> > meets too much resistance I'll remove them.
>
> You already have comment there, but let's see what the others think.

i think it's fine. delay slots are a pita enough to deal with, so slight style
tweaks that make this easier are a good thing.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111122/f8fa8d17/attachment.pgp>