From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Tue, 22 Nov 2011 15:21:22 +0100
Subject: [U-Boot] [PATCH] M28: Fix OB1 bug in GPIO driver
In-Reply-To: <B0658F55E67EDE4A914644632835B2CAF7E57B@DEUTERIUM.delien.local>
References: <B0658F55E67EDE4A914644632835B2CAF7E57B@DEUTERIUM.delien.local>
Message-ID: <201111221521.23025.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> This patch fixes a small off-by-one bug in the GPIO driver for the mxs
> platform that allowed the selection gpio pins of one bank more than the
> SoC actually has.
> 
> Signed-off-by: Robert Deli?n <robert@delien.nl>
> 
> diff --git a/drivers/gpio/mxs_gpio.c b/drivers/gpio/mxs_gpio.c
> index b7e9591..539738b 100644
> --- a/drivers/gpio/mxs_gpio.c
> +++ b/drivers/gpio/mxs_gpio.c
> @@ -120,7 +120,7 @@ int gpio_direction_output(int gp, int value)
> 
>  int gpio_request(int gp, const char *label)
>  {
> -       if (PAD_BANK(gp) > PINCTRL_BANKS)
> +       if (PAD_BANK(gp) >= PINCTRL_BANKS)
>                 return -EINVAL;
> 
>         return 0;

Good catch, I'll verify and ack afterwards.

Thanks

M