From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/9] openrisc: Add cpu files
Date: Tue, 22 Nov 2011 15:54:03 -0500 [thread overview]
Message-ID: <201111221554.04368.vapier@gentoo.org> (raw)
In-Reply-To: <201111220546.41715.marek.vasut@gmail.com>
On Monday 21 November 2011 23:46:41 Marek Vasut wrote:
> > On Mon, Nov 21, 2011 at 11:50:17PM +0100, Marek Vasut wrote:
> > > > + l.addi r3,r3,4
> > > > + l.sfltu r4,r5
> > > > + l.bf .L_reloc
> > > > + l.addi r4,r4,4 /* delay slot */
> > >
> > > The formating here doesn't seem right?
> >
> > The extra space there is to denote that the instruction is
> > in a delay slot.
> > I think it brings more readability to the code, but if it
> > meets too much resistance I'll remove them.
>
> You already have comment there, but let's see what the others think.
i think it's fine. delay slots are a pita enough to deal with, so slight style
tweaks that make this easier are a good thing.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111122/f8fa8d17/attachment.pgp>
next prev parent reply other threads:[~2011-11-22 20:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-19 5:21 [U-Boot] [PATCH 0/9] Add support for the OpenRISC architecture Stefan Kristiansson
2011-11-19 5:21 ` [U-Boot] [PATCH 1/9] openrisc: Add architecture header files Stefan Kristiansson
2011-11-19 6:06 ` Mike Frysinger
2011-11-19 5:21 ` [U-Boot] [PATCH 2/9] openrisc: Add architecture image support Stefan Kristiansson
2011-11-21 22:45 ` Marek Vasut
2011-11-22 9:43 ` [U-Boot] [PATCH] Fix clash between IH_ARCH_NDS32 and IH_ARCH_SANDBOX Stefan Kristiansson
2011-11-22 11:03 ` [U-Boot] 回覆: " macpaul at andestech.com
2011-11-22 14:15 ` Marek Vasut
2011-11-23 6:10 ` Macpaul Lin
2011-11-19 5:21 ` [U-Boot] [PATCH 3/9] openrisc: Add cpu files Stefan Kristiansson
2011-11-19 5:59 ` Mike Frysinger
2011-11-20 4:27 ` Stefan Kristiansson
2011-11-20 5:27 ` Mike Frysinger
2011-11-21 22:50 ` Marek Vasut
2011-11-22 3:51 ` Stefan Kristiansson
2011-11-22 4:46 ` Marek Vasut
2011-11-22 7:17 ` Stefan Kristiansson
2011-11-22 14:07 ` Marek Vasut
2011-11-22 20:29 ` Scott Wood
2011-11-22 20:54 ` Mike Frysinger [this message]
2011-11-19 5:21 ` [U-Boot] [PATCH 4/9] openrisc: Add library functions Stefan Kristiansson
2011-11-19 6:04 ` Mike Frysinger
2011-11-21 22:52 ` Marek Vasut
2011-11-22 4:19 ` Stefan Kristiansson
2011-11-22 4:48 ` Marek Vasut
2011-11-22 6:00 ` Stefan Kristiansson
2011-11-22 14:10 ` Marek Vasut
2011-11-19 5:21 ` [U-Boot] [PATCH 5/9] openrisc: Add board info printout to cmd_bdinfo Stefan Kristiansson
2011-11-21 22:53 ` Marek Vasut
2011-11-22 4:30 ` Stefan Kristiansson
2011-11-22 4:49 ` Marek Vasut
2011-11-19 5:21 ` [U-Boot] [PATCH 6/9] openrisc: Add support for standalone programs Stefan Kristiansson
2011-11-19 5:21 ` [U-Boot] [PATCH 7/9] openrisc: Add openrisc-generic example board Stefan Kristiansson
2011-11-19 5:21 ` [U-Boot] [PATCH 8/9] openrisc: Add architecture to MAKEALL Stefan Kristiansson
2011-11-19 5:21 ` [U-Boot] [PATCH 9/9] openrisc: Add MAINTAINERS entry Stefan Kristiansson
2011-11-21 22:54 ` Marek Vasut
2011-11-22 4:32 ` Stefan Kristiansson
2011-11-19 6:07 ` [U-Boot] [PATCH 0/9] Add support for the OpenRISC architecture Mike Frysinger
2011-11-19 7:23 ` Stefan Kristiansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111221554.04368.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox