From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH v2 12/12] arm, davinci: Add support for generating AIS images to the Makefile
Date: Tue, 22 Nov 2011 15:57:42 -0500 [thread overview]
Message-ID: <201111221557.43197.vapier@gentoo.org> (raw)
In-Reply-To: <CABkLObqPGu8UujwLFdXaivKOAW9NmCv6jf=DL_KdLRBv982M4w@mail.gmail.com>
On Tuesday 22 November 2011 02:30:59 Christian Riesch wrote:
> Hello Mike,
> Thank you for your comments.
>
> On Mon, Nov 21, 2011 at 8:09 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Monday 21 November 2011 11:33:47 Christian Riesch wrote:
> >> --- a/Makefile
> >> +++ b/Makefile
> >>
> >> +$(obj)u-boot.ais: $(obj)spl/u-boot-spl.bin $(obj)u-boot.bin
> >> + $(obj)tools/mkimage -s -n /dev/null -T aisimage \
> >> + -e $(CONFIG_SPL_TEXT_BASE) -d $(obj)spl/u-boot-spl.bin \
> >> + $(obj)spl/u-boot-spl.ais
> >> + $(OBJCOPY) ${OBJCFLAGS} -I binary --pad-to=$(PAD_TO) -O
> >> binary $(obj)spl/u-boot-spl.ais $(obj)spl/u-boot-spl-pad.ais +
> >> cat $(obj)spl/u-boot-spl-pad.ais $(obj)u-boot.bin >
> >> $(obj)u-boot.ais + rm $(obj)spl/u-boot-spl.ais
> >> + rm $(obj)spl/u-boot-spl-pad.ais
> >> +
> >
> > can't this live in arch/arm/.../config.mk somewhere ?
>
> I guess it could. I placed it in Makefile since there are already a
> lot of similar targets there, like $(obj)u-boot.kwb, $(obj)u-boot.imx,
> $(obj)u-boot.ubl...
we need to clean this up. if moving the target to a cpu config.mk doesn't
work, then we can leave it alone for now until we generally clean this cruft
up.
> >> --- /dev/null
> >> +++ b/board/davinci/da8xxevm/config.mk
> >>
> >> +# required for SPI flash SPL
> >> +#
> >> +
> >> +PAD_TO := 32768
> >
> > "PAD_TO" is way too generic a name. this should also be a CONFIG_XXX
> > define in the board config header rather than using config.mk.
>
> Ok. I'll find a different name. I used $(PAD_TO) since the
> $(obj)u-boot.ubl target in Makefile already uses this name.
we should fix that too ;)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111122/f4282827/attachment.pgp>
prev parent reply other threads:[~2011-11-22 20:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1321893227-19545-1-git-send-email-christian.riesch@omicron.at>
2011-11-21 16:33 ` [U-Boot] [RFC PATCH v2 00/12] *** SUBJECT HERE *** Christian Riesch
2011-11-21 16:33 ` [U-Boot] [RFC PATCH v2 01/12] arm, davinci: Move pinmux functions from board to arch tree Christian Riesch
2011-11-21 16:33 ` [U-Boot] [RFC PATCH v2 02/12] arm, hawkboard: Remove obsolete struct pinmux_config i2c_pins Christian Riesch
2011-11-21 16:33 ` [U-Boot] [RFC PATCH v2 03/12] arm, da850: Move the definitions of pinmux configurations to the arch tree Christian Riesch
2011-11-21 19:03 ` Mike Frysinger
2011-11-22 7:26 ` Christian Riesch
2011-11-21 16:33 ` [U-Boot] [RFC PATCH v2 04/12] arm, da830: " Christian Riesch
2011-11-21 16:33 ` [U-Boot] [RFC PATCH v2 05/12] arm, davinci: Remove duplication of pinmux configuration code Christian Riesch
2011-11-21 16:33 ` [U-Boot] [RFC PATCH v2 06/12] arm, davinci: Fix clear bss loop for zero length bss Christian Riesch
2011-11-21 16:33 ` [U-Boot] [RFC PATCH v2 07/12] arm: printf() is not available in some SPL configurations Christian Riesch
2011-11-21 17:52 ` Tom Rini
2011-11-22 7:01 ` Christian Riesch
2011-11-21 16:33 ` [U-Boot] [RFC PATCH v2 08/12] sf: Add spi_boot() to allow booting from SPI flash in an SPL Christian Riesch
2011-11-21 19:07 ` Mike Frysinger
2011-11-21 19:13 ` Scott Wood
2011-11-22 7:35 ` Christian Riesch
2011-11-21 16:33 ` [U-Boot] [RFC PATCH v2 09/12] arm, davinci: Add SPL support for DA850 SoCs Christian Riesch
2011-11-21 16:33 ` [U-Boot] [RFC PATCH v2 10/12] arm, da850evm: Add an SPL for SPI boot Christian Riesch
2011-11-21 16:33 ` [U-Boot] [RFC PATCH v2 11/12] mkimage: Fix variable length header support Christian Riesch
2011-11-21 16:33 ` [U-Boot] [RFC PATCH v2 12/12] arm, davinci: Add support for generating AIS images to the Makefile Christian Riesch
2011-11-21 19:09 ` Mike Frysinger
2011-11-22 7:30 ` Christian Riesch
2011-11-22 20:57 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111221557.43197.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox