From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm, post: add missing post_time_ms for arm
Date: Tue, 22 Nov 2011 16:00:31 -0500 [thread overview]
Message-ID: <201111221600.31920.vapier@gentoo.org> (raw)
In-Reply-To: <1316064873-5500-1-git-send-email-hs@denx.de>
On Thursday 15 September 2011 01:34:33 Heiko Schocher wrote:
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
> post/post.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/post/post.c b/post/post.c
> index 6c59f91..0bfca75 100644
> --- a/post/post.c
> +++ b/post/post.c
> @@ -488,7 +488,7 @@ void post_reloc(void)
> */
> unsigned long post_time_ms(unsigned long base)
> {
> -#ifdef CONFIG_PPC
> +#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
> return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
> - base;
> #else
almost no one uses the result of post_time_ms(), so the warning ends up being
spurious for most people.
are you enabling this define because you need the result ? or you just trying
to kill the warning ? if the latter, i think we should make this so it warns
only when appropriate ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111122/b73fe3fa/attachment.pgp>
prev parent reply other threads:[~2011-11-22 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 5:34 [U-Boot] [PATCH] arm, post: add missing post_time_ms for arm Heiko Schocher
2011-11-21 12:57 ` Holger Brunck
2011-11-21 14:09 ` Heiko Schocher
2011-11-21 14:27 ` Holger Brunck
2011-11-22 8:26 ` Prafulla Wadaskar
2011-11-22 21:00 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111221600.31920.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox