From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] M28: Added pin name support in GPIO driver
Date: Tue, 22 Nov 2011 16:11:48 -0500 [thread overview]
Message-ID: <201111221611.48987.vapier@gentoo.org> (raw)
In-Reply-To: <B0658F55E67EDE4A914644632835B2CAF7F1E5@DEUTERIUM.delien.local>
On Tuesday 22 November 2011 10:40:24 Robert Deli?n wrote:
> +static inline int name_to_gpio(const char *name)
> +{
> + int pin_nr;
single space after that "int"
> + if (name[0] >= '0' && name[0] <= '9') {
> + pin_nr = simple_strtoul(name, (char **)&name, 10);
NAK: that 2nd arg is wrong. if you want to check the endp value, then declare
a local variable and pass that in.
same goes to all other calls to simple_strtoul() in this func
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111122/c29eeda0/attachment.pgp>
next prev parent reply other threads:[~2011-11-22 21:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 15:40 [U-Boot] [PATCH] M28: Added pin name support in GPIO driver Robert Deliën
2011-11-22 18:28 ` Marek Vasut
2011-11-22 19:13 ` Robert Deliën
2011-11-22 19:32 ` Marek Vasut
2011-11-22 20:49 ` Robert Deliën
2011-11-22 22:18 ` Mike Frysinger
2011-11-22 22:37 ` Marek Vasut
2011-11-23 10:08 ` Robert Deliën
2011-11-23 22:18 ` Mike Frysinger
2011-11-22 21:10 ` Mike Frysinger
2011-11-22 21:11 ` Mike Frysinger [this message]
2011-11-23 9:07 ` Stefano Babic
2011-11-23 9:51 ` Robert Deliën
2011-11-23 22:11 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111221611.48987.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox