[U-Boot] [PATCH] M28: Added pin name support in GPIO driver

Mike Frysinger
2011-11-22T21:11:48Z

On Tuesday 22 November 2011 10:40:24 Robert Deli?n wrote:
> +static inline int name_to_gpio(const char *name)
> +{
> + int pin_nr;

single space after that "int"

> + if (name[0] >= '0' && name[0] <= '9') {
> + pin_nr = simple_strtoul(name, (char **)&name, 10);

NAK: that 2nd arg is wrong. if you want to check the endp value, then declare
a local variable and pass that in.

same goes to all other calls to simple_strtoul() in this func
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111122/c29eeda0/attachment.pgp>