From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] M28: Added pin name support in GPIO driver
Date: Tue, 22 Nov 2011 23:37:49 +0100 [thread overview]
Message-ID: <201111222337.49784.marek.vasut@gmail.com> (raw)
In-Reply-To: <201111221718.12738.vapier@gentoo.org>
> On Tuesday 22 November 2011 15:49:06 Robert Deli?n wrote:
> > Of course name_to_gpio could be a non-static function, allowing it to be
> > used by other parts of the code too. And for that reason do_gpio could be
> > non-static too. But that would still require an ifdef-orgy like this to
>
> > make it work for different diversities:
> no it doesn't. you can have it be an external function in the gpio.c file
> like Marek wants, and then the header simply does:
> extern int name_to_gpio(unsigned gpio);
> #define name_to_gpio(gpio) name_to_gpio(gpio)
> -mike
Man, this is really ... urgh. But fine, it's better than it was anyway.
M
next prev parent reply other threads:[~2011-11-22 22:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 15:40 [U-Boot] [PATCH] M28: Added pin name support in GPIO driver Robert Deliën
2011-11-22 18:28 ` Marek Vasut
2011-11-22 19:13 ` Robert Deliën
2011-11-22 19:32 ` Marek Vasut
2011-11-22 20:49 ` Robert Deliën
2011-11-22 22:18 ` Mike Frysinger
2011-11-22 22:37 ` Marek Vasut [this message]
2011-11-23 10:08 ` Robert Deliën
2011-11-23 22:18 ` Mike Frysinger
2011-11-22 21:10 ` Mike Frysinger
2011-11-22 21:11 ` Mike Frysinger
2011-11-23 9:07 ` Stefano Babic
2011-11-23 9:51 ` Robert Deliën
2011-11-23 22:11 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111222337.49784.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox