From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 22 Nov 2011 23:37:49 +0100 Subject: [U-Boot] [PATCH] M28: Added pin name support in GPIO driver In-Reply-To: <201111221718.12738.vapier@gentoo.org> References: <7E702972-7AC1-40E4-BBBD-C81AA3D81359@delien.nl> <201111221718.12738.vapier@gentoo.org> Message-ID: <201111222337.49784.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > On Tuesday 22 November 2011 15:49:06 Robert Deli?n wrote: > > Of course name_to_gpio could be a non-static function, allowing it to be > > used by other parts of the code too. And for that reason do_gpio could be > > non-static too. But that would still require an ifdef-orgy like this to > > > make it work for different diversities: > no it doesn't. you can have it be an external function in the gpio.c file > like Marek wants, and then the header simply does: > extern int name_to_gpio(unsigned gpio); > #define name_to_gpio(gpio) name_to_gpio(gpio) > -mike Man, this is really ... urgh. But fine, it's better than it was anyway. M