From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MX: serial_mxc: cleanup removing nasty #ifdef
Date: Wed, 23 Nov 2011 11:44:49 +0100 [thread overview]
Message-ID: <201111231144.49301.marek.vasut@gmail.com> (raw)
In-Reply-To: <4ECCB0B6.9060807@denx.de>
> On 23/11/2011 03:48, Jason Hui wrote:
> > From the u-boot/README:
> >
> > * Configuration _OPTIONS_:
> > These are selectable by the user and have names beginning with
> > "CONFIG_".
> >
> > * Configuration _SETTINGS_:
> > These depend on the hardware etc. and should not be meddled with if
> > you don't know what you're doing; they have names beginning with
> > "CONFIG_SYS_".
> >
> > It's better to use #define CONFIG_SYS_MXC_UART_BASE UART1_BASE
> >
> > [...]
>
> Agree, I do it in V2
>
> Best regards,
> Stefano Babic
But this is not completely right. Why CONFIG_SYS, if the user can change it
quite safely to adjust his serial port.
M
next prev parent reply other threads:[~2011-11-23 10:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 15:51 [U-Boot] [PATCH] MX: serial_mxc: cleanup removing nasty #ifdef Stefano Babic
2011-11-22 18:06 ` Marek Vasut
2011-11-23 8:41 ` Stefano Babic
2011-11-23 2:48 ` Jason Hui
2011-11-23 8:37 ` Stefano Babic
2011-11-23 10:44 ` Marek Vasut [this message]
2011-11-23 21:27 ` stefano babic
2011-11-24 0:08 ` Marek Vasut
2011-11-24 2:35 ` Jason Hui
2011-11-24 2:44 ` Marek Vasut
2011-11-24 11:35 ` Wolfgang Denk
2011-11-24 6:13 ` Wolfgang Denk
2011-11-24 6:23 ` Jason Hui
2011-11-24 11:41 ` Wolfgang Denk
2011-11-24 11:47 ` Jason Hui
2011-11-24 12:11 ` Wolfgang Denk
2011-11-25 2:11 ` Jason Hui
2011-11-25 3:32 ` Jason Hui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111231144.49301.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox