From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 23 Nov 2011 11:44:49 +0100 Subject: [U-Boot] [PATCH] MX: serial_mxc: cleanup removing nasty #ifdef In-Reply-To: <4ECCB0B6.9060807@denx.de> References: <1321977108-21243-1-git-send-email-sbabic@denx.de> <4ECCB0B6.9060807@denx.de> Message-ID: <201111231144.49301.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > On 23/11/2011 03:48, Jason Hui wrote: > > From the u-boot/README: > > > > * Configuration _OPTIONS_: > > These are selectable by the user and have names beginning with > > "CONFIG_". > > > > * Configuration _SETTINGS_: > > These depend on the hardware etc. and should not be meddled with if > > you don't know what you're doing; they have names beginning with > > "CONFIG_SYS_". > > > > It's better to use #define CONFIG_SYS_MXC_UART_BASE UART1_BASE > > > > [...] > > Agree, I do it in V2 > > Best regards, > Stefano Babic But this is not completely right. Why CONFIG_SYS, if the user can change it quite safely to adjust his serial port. M