From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] tegra: Move cpu_init_cp15() to arch_cpu_init()
Date: Wed, 23 Nov 2011 18:34:21 -0500 [thread overview]
Message-ID: <201111231834.22560.vapier@gentoo.org> (raw)
In-Reply-To: <1322089148-2810-2-git-send-email-sjg@chromium.org>
On Wednesday 23 November 2011 17:59:03 Simon Glass wrote:
> --- a/arch/arm/cpu/armv7/tegra2/board.c
> +++ b/arch/arm/cpu/armv7/tegra2/board.c
> @@ -80,6 +80,9 @@ int arch_cpu_init(void)
> {
> /* Fire up the Cortex A9 */
> tegra2_start();
> +
> + /* We didn't do this init in start.S, so do it now */
> + cpu_init_cp15();
> return 0;
> }
probably a pain since you've got a bunch of little patches, but there should
be a blank line before that return statement. it was semi-OK because before
there were only two statements in this func, but now that there are more, the
return should be by itself.
i'll leave it up to you/tegra-maintainer if this really needs to get fixed in
all the patches, or just the last one.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111123/1b9d9934/attachment.pgp>
next prev parent reply other threads:[~2011-11-23 23:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 22:59 [U-Boot] [PATCH 0/6] Introduce function mux library Simon Glass
2011-11-23 22:59 ` [U-Boot] [PATCH 1/6] tegra: Move cpu_init_cp15() to arch_cpu_init() Simon Glass
2011-11-23 23:34 ` Mike Frysinger [this message]
2011-11-28 19:00 ` Simon Glass
2011-11-28 18:12 ` Stephen Warren
2011-11-23 22:59 ` [U-Boot] [PATCH 2/6] tegra: Move clock_early_init() " Simon Glass
2011-11-28 18:12 ` Stephen Warren
2011-11-23 22:59 ` [U-Boot] [PATCH 3/6] tegra: Add a function mux feature Simon Glass
2011-11-23 23:36 ` Mike Frysinger
2011-11-28 18:17 ` Stephen Warren
2011-11-28 19:19 ` Simon Glass
2011-11-28 19:42 ` Stephen Warren
2011-11-28 22:57 ` Simon Glass
2011-11-23 22:59 ` [U-Boot] [PATCH 4/6] tegra: Add support for UART init in cpu board.c Simon Glass
2011-11-23 23:40 ` Mike Frysinger
2011-11-28 20:14 ` Simon Glass
2011-11-28 23:06 ` Mike Frysinger
2011-11-29 0:40 ` Simon Glass
2011-11-23 22:59 ` [U-Boot] [PATCH 5/6] tegra: Move boards over to use arch-level board UART function Simon Glass
2011-11-23 22:59 ` [U-Boot] [PATCH 6/6] tegra: Fix build error in plutux, medcom Simon Glass
2011-11-23 23:42 ` Mike Frysinger
2011-11-24 20:04 ` Thierry Reding
2011-11-28 18:18 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111231834.22560.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox