From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/6] tegra: Add support for UART init in cpu board.c
Date: Wed, 23 Nov 2011 18:40:23 -0500 [thread overview]
Message-ID: <201111231840.24573.vapier@gentoo.org> (raw)
In-Reply-To: <1322089148-2810-5-git-send-email-sjg@chromium.org>
On Wednesday 23 November 2011 17:59:06 Simon Glass wrote:
> --- a/arch/arm/cpu/armv7/tegra2/board.c
> +++ b/arch/arm/cpu/armv7/tegra2/board.c
>
> +static void setup_uarts(int uart_ids)
> +{
> + static enum periph_id id_for_uart[UART_COUNT] = {
> + PERIPH_ID_UART1,
> + PERIPH_ID_UART2,
> + PERIPH_ID_UART3,
> + PERIPH_ID_UART4,
> + };
does this need the [UART_COUNT] ? what if you used "[]" ...
> + int i;
size_t
> + for (i = 0; i < UART_COUNT; i++) {
... and then did ARRAY_SIZE(id_for_uart) ?
> +void board_init_uart_f(void)
> +{
> + int uart_ids = 0; /* bit mask of which UART ids to enable */
> +
> +#ifdef CONFIG_TEGRA2_ENABLE_UARTA
> + uart_ids |= UARTA;
> +#endif
> +#ifdef CONFIG_TEGRA2_ENABLE_UARTB
> + uart_ids |= UARTB;
> +#endif
> +#ifdef CONFIG_TEGRA2_ENABLE_UARTD
> + uart_ids |= UARTD;
> +#endif
> + setup_uarts(uart_ids);
> +}
we added a func in the Blackfin pinmux API where you could pass it a list of
peripherals to mux. so you could do:
static const unsigned pin_list[] = {
#ifdef CONFIG_TEGRA2_ENABLE_UARTA
UART1,
#endif
0,
};
pinmux_request_list(pin_list);
and the list version would just walk the 0-terminated array calling
pinmux_request() automatically
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111123/4d270357/attachment.pgp>
next prev parent reply other threads:[~2011-11-23 23:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 22:59 [U-Boot] [PATCH 0/6] Introduce function mux library Simon Glass
2011-11-23 22:59 ` [U-Boot] [PATCH 1/6] tegra: Move cpu_init_cp15() to arch_cpu_init() Simon Glass
2011-11-23 23:34 ` Mike Frysinger
2011-11-28 19:00 ` Simon Glass
2011-11-28 18:12 ` Stephen Warren
2011-11-23 22:59 ` [U-Boot] [PATCH 2/6] tegra: Move clock_early_init() " Simon Glass
2011-11-28 18:12 ` Stephen Warren
2011-11-23 22:59 ` [U-Boot] [PATCH 3/6] tegra: Add a function mux feature Simon Glass
2011-11-23 23:36 ` Mike Frysinger
2011-11-28 18:17 ` Stephen Warren
2011-11-28 19:19 ` Simon Glass
2011-11-28 19:42 ` Stephen Warren
2011-11-28 22:57 ` Simon Glass
2011-11-23 22:59 ` [U-Boot] [PATCH 4/6] tegra: Add support for UART init in cpu board.c Simon Glass
2011-11-23 23:40 ` Mike Frysinger [this message]
2011-11-28 20:14 ` Simon Glass
2011-11-28 23:06 ` Mike Frysinger
2011-11-29 0:40 ` Simon Glass
2011-11-23 22:59 ` [U-Boot] [PATCH 5/6] tegra: Move boards over to use arch-level board UART function Simon Glass
2011-11-23 22:59 ` [U-Boot] [PATCH 6/6] tegra: Fix build error in plutux, medcom Simon Glass
2011-11-23 23:42 ` Mike Frysinger
2011-11-24 20:04 ` Thierry Reding
2011-11-28 18:18 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111231840.24573.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox