public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] M28: Added pin name support in GPIO driver
Date: Wed, 23 Nov 2011 22:00:42 +0100	[thread overview]
Message-ID: <201111232200.42556.marek.vasut@gmail.com> (raw)
In-Reply-To: <7677D461-85D5-4EB1-AE0F-711BF87567B3@delien.nl>

> >> +
> >> +	if (name[0])
> >> +		return (-EINVAL);
> > 
> > Why the parenthesis ?
> 
> Because you asked for them? But OK, I'll remove them again...

I asked you to add braces around the else part of the branch!
if { ... } else { ... } ... this stuff. Sorry for the confusion!

> 
> >> +
> >> +	return ( ((bank << MXS_PAD_BANK_SHIFT) & MXS_PAD_BANK_MASK) |
> >> +		 ((pin  << MXS_PAD_PIN_SHIFT ) & MXS_PAD_PIN_MASK ) );
> >> +}
> >> +
> >> int gpio_invalid(int gp)
> >> {
> >> 
> >> 	if ( (gp & ~(MXS_PAD_BANK_MASK | MXS_PAD_PIN_MASK)) ||
> > 
> > This was there before or are we missing some previous commit here ?
> 
> To apply cleanly, this patch needs the pin validity patch applied first.
> However, it will apply without it, yet not cleanly.

I think I didn't see the pin validity patch then.

  reply	other threads:[~2011-11-23 21:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23 15:44 [U-Boot] [PATCH v2] M28: Added pin name support in GPIO driver Robert Deliën
2011-11-23 20:24 ` Marek Vasut
2011-11-23 20:43   ` Robert Deliën
2011-11-23 21:00     ` Marek Vasut [this message]
2011-11-23 21:12       ` Robert Deliën

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111232200.42556.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox