From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning
Date: Thu, 24 Nov 2011 18:30:18 +0100 [thread overview]
Message-ID: <201111241830.18559.marek.vasut@gmail.com> (raw)
In-Reply-To: <201111241816.32862.marek.vasut@gmail.com>
> > Fix:
> >
> > interactive.c: In function 'fsl_ddr_interactive':
> > interactive.c:1357:15: warning: variable 'len' set but not used
> > [-Wunused-but-set-variable]
> >
> > Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> > ---
> >
> > arch/powerpc/cpu/mpc8xxx/ddr/interactive.c | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> > b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c index d7d66ef..5b72437
> > 100644 --- a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> > +++ b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> > @@ -1354,7 +1354,6 @@ unsigned long long
> > fsl_ddr_interactive(fsl_ddr_info_t *pinfo) {
> >
> > unsigned long long ddrsize;
> > const char *prompt = "FSL DDR>";
> >
> > - unsigned int len;
> >
> > char buffer[CONFIG_SYS_CBSIZE];
> > char *argv[CONFIG_SYS_MAXARGS + 1]; /* NULL terminated */
> > int argc;
> >
> > @@ -1389,7 +1388,7 @@ unsigned long long
> > fsl_ddr_interactive(fsl_ddr_info_t *pinfo) * No need to worry for buffer
> > overflow here in
> >
> > * this function; readline() maxes out at CFG_CBSIZE
> > */
> >
> > - len = readline_into_buffer(prompt, buffer);
> > + readline_into_buffer(prompt, buffer);
> >
> > argc = parse_line(buffer, argv);
> > if (argc == 0)
> >
> > continue;
>
> Ok, I'll pick this one.
Picked to:
u-boot-staging.git / marek.vasut at gmail.com
prev parent reply other threads:[~2011-11-24 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 16:03 [U-Boot] [PATCH] arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning Kumar Gala
2011-11-24 17:16 ` Marek Vasut
2011-11-24 17:30 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111241830.18559.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox