* [U-Boot] [PATCH] arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning
@ 2011-11-23 16:03 Kumar Gala
2011-11-24 17:16 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Kumar Gala @ 2011-11-23 16:03 UTC (permalink / raw)
To: u-boot
Fix:
interactive.c: In function 'fsl_ddr_interactive':
interactive.c:1357:15: warning: variable 'len' set but not used [-Wunused-but-set-variable]
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
arch/powerpc/cpu/mpc8xxx/ddr/interactive.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
index d7d66ef..5b72437 100644
--- a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
+++ b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
@@ -1354,7 +1354,6 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo)
{
unsigned long long ddrsize;
const char *prompt = "FSL DDR>";
- unsigned int len;
char buffer[CONFIG_SYS_CBSIZE];
char *argv[CONFIG_SYS_MAXARGS + 1]; /* NULL terminated */
int argc;
@@ -1389,7 +1388,7 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo)
* No need to worry for buffer overflow here in
* this function; readline() maxes out at CFG_CBSIZE
*/
- len = readline_into_buffer(prompt, buffer);
+ readline_into_buffer(prompt, buffer);
argc = parse_line(buffer, argv);
if (argc == 0)
continue;
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning
2011-11-23 16:03 [U-Boot] [PATCH] arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning Kumar Gala
@ 2011-11-24 17:16 ` Marek Vasut
2011-11-24 17:30 ` Marek Vasut
0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2011-11-24 17:16 UTC (permalink / raw)
To: u-boot
> Fix:
>
> interactive.c: In function 'fsl_ddr_interactive':
> interactive.c:1357:15: warning: variable 'len' set but not used
> [-Wunused-but-set-variable]
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> arch/powerpc/cpu/mpc8xxx/ddr/interactive.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c index d7d66ef..5b72437 100644
> --- a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> +++ b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> @@ -1354,7 +1354,6 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t
> *pinfo) {
> unsigned long long ddrsize;
> const char *prompt = "FSL DDR>";
> - unsigned int len;
> char buffer[CONFIG_SYS_CBSIZE];
> char *argv[CONFIG_SYS_MAXARGS + 1]; /* NULL terminated */
> int argc;
> @@ -1389,7 +1388,7 @@ unsigned long long fsl_ddr_interactive(fsl_ddr_info_t
> *pinfo) * No need to worry for buffer overflow here in
> * this function; readline() maxes out at CFG_CBSIZE
> */
> - len = readline_into_buffer(prompt, buffer);
> + readline_into_buffer(prompt, buffer);
> argc = parse_line(buffer, argv);
> if (argc == 0)
> continue;
Ok, I'll pick this one.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning
2011-11-24 17:16 ` Marek Vasut
@ 2011-11-24 17:30 ` Marek Vasut
0 siblings, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2011-11-24 17:30 UTC (permalink / raw)
To: u-boot
> > Fix:
> >
> > interactive.c: In function 'fsl_ddr_interactive':
> > interactive.c:1357:15: warning: variable 'len' set but not used
> > [-Wunused-but-set-variable]
> >
> > Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> > ---
> >
> > arch/powerpc/cpu/mpc8xxx/ddr/interactive.c | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> > b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c index d7d66ef..5b72437
> > 100644 --- a/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> > +++ b/arch/powerpc/cpu/mpc8xxx/ddr/interactive.c
> > @@ -1354,7 +1354,6 @@ unsigned long long
> > fsl_ddr_interactive(fsl_ddr_info_t *pinfo) {
> >
> > unsigned long long ddrsize;
> > const char *prompt = "FSL DDR>";
> >
> > - unsigned int len;
> >
> > char buffer[CONFIG_SYS_CBSIZE];
> > char *argv[CONFIG_SYS_MAXARGS + 1]; /* NULL terminated */
> > int argc;
> >
> > @@ -1389,7 +1388,7 @@ unsigned long long
> > fsl_ddr_interactive(fsl_ddr_info_t *pinfo) * No need to worry for buffer
> > overflow here in
> >
> > * this function; readline() maxes out at CFG_CBSIZE
> > */
> >
> > - len = readline_into_buffer(prompt, buffer);
> > + readline_into_buffer(prompt, buffer);
> >
> > argc = parse_line(buffer, argv);
> > if (argc == 0)
> >
> > continue;
>
> Ok, I'll pick this one.
Picked to:
u-boot-staging.git / marek.vasut at gmail.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-24 17:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-23 16:03 [U-Boot] [PATCH] arch/powerpc/cpu/mpc8xxx/ddr/interactive.c: Fix GCC 4.6 build warning Kumar Gala
2011-11-24 17:16 ` Marek Vasut
2011-11-24 17:30 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox