public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] drivers/bios_emulator/x86emu/ops2.c: Fix GCC 4.6 build warning
Date: Thu, 24 Nov 2011 23:31:31 +0100	[thread overview]
Message-ID: <201111242331.31938.marek.vasut@gmail.com> (raw)
In-Reply-To: <20111124204806.5E7691FFB39F@gemini.denx.de>

Hi,

> Dear Marek Vasut,
> 
> In message <201111241814.34611.marek.vasut@gmail.com> you wrote:
> > > -    char *name = 0;
> > > +    __maybe_unused char *name = 0;
> > 
> > I don't like this __maybe_unused stuff, it seems like you're hiding
> > possible errors.
> 
> I don't like it either, but there are cases where this is the cheapest
> way to get the code clean again, and still working.
> 
> If you have a better proposal to make this file compile clean, without
> using __maybe_unused, then please post your patch.
> 
Honestly, not right now. I'd prefer to work on other stuff that's slightly more 
important (mx51usb, bootz ... pile of other stuff). This patch is of moderate 
importance to me (which means I'll think about it when I'm idle).

Anyway, from now on, I'd like to try picking up gcc4.6 fixes (as I started whole 
this machinery with the debug() macro changes) and start pushing it through -
staging. Are you against it?

M

  reply	other threads:[~2011-11-24 22:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23 16:31 [U-Boot] [PATCH] drivers/bios_emulator/x86emu/ops2.c: Fix GCC 4.6 build warning Kumar Gala
2011-11-24 17:14 ` Marek Vasut
2011-11-24 19:11   ` Kumar Gala
2011-11-24 20:48   ` Wolfgang Denk
2011-11-24 22:31     ` Marek Vasut [this message]
2011-11-27 14:45 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111242331.31938.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox