From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 25 Nov 2011 14:41:15 +0100 Subject: [U-Boot] [PATCH 02/11] MIPS: board.c: fix warning if CONFIG_CMD_NET is not defined In-Reply-To: References: <1322143076-20349-1-git-send-email-daniel.schwierzeck@googlemail.com> <201111250939.35663.marek.vasut@gmail.com> Message-ID: <201111251441.15343.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > On Fri, Nov 25, 2011 at 9:39 AM, Marek Vasut wrote: > >> board.c: In function 'board_init_r': > >> board.c:280:8: warning: unused variable 's' > >> > >> Signed-off-by: Daniel Schwierzeck > >> --- > >> arch/mips/lib/board.c | 3 +-- > >> 1 files changed, 1 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/mips/lib/board.c b/arch/mips/lib/board.c > >> index 9585db7..aac7690 100644 > >> --- a/arch/mips/lib/board.c > >> +++ b/arch/mips/lib/board.c > >> @@ -266,7 +266,6 @@ void board_init_r(gd_t *id, ulong dest_addr) > >> #ifndef CONFIG_ENV_IS_NOWHERE > >> extern char *env_name_spec; > >> #endif > >> - char *s; > >> bd_t *bd; > >> > >> gd = id; > >> @@ -347,7 +346,7 @@ void board_init_r(gd_t *id, ulong dest_addr) > >> /* Initialize from environment */ > >> load_addr = getenv_ulong("loadaddr", 16, load_addr); > >> #if defined(CONFIG_CMD_NET) > >> - s = getenv("bootfile"); > >> + const char *s = getenv("bootfile"); > >> if (s) > >> copy_filename(BootFile, s, sizeof(BootFile)); > >> #endif > > > > Are you sure about this "const" thing? Also, try compiling the stuff with > > gcc4.6, it'll reveal more errors. > > yes, s is only used in the if and as parameter for copy_filename. The > function signature > also have const: > > extern void copy_filename (char *dst, const char *src, int size); > > And gcc-4.6.2 compiles that part without warnings. Ok, that's good then! :)