From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 7/7] reboard: arm: Remove unused code in start.S
Date: Mon, 28 Nov 2011 22:15:38 -0500 [thread overview]
Message-ID: <201111282215.39824.vapier@gentoo.org> (raw)
In-Reply-To: <1321919880-10070-8-git-send-email-sjg@chromium.org>
On Monday 21 November 2011 18:58:00 Simon Glass wrote:
> --- a/board/reloc.c
> +++ b/board/reloc.c
>
> -void new_relocate_code(ulong dest_addr_sp, gd_t *new_gd, ulong dest_addr)
> +void relocate_code(ulong dest_addr_sp, gd_t *new_gd, ulong dest_addr)
this is too fragile. we can't have every arch transition the way you did with
arm (otherwise arches that have transitioned will break in between). declare
this func weak and don't rename it. then there should be no migration issue.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111128/4f1806d9/attachment.pgp>
next prev parent reply other threads:[~2011-11-29 3:15 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 23:57 [U-Boot] [RFC PATCH 0/7] reboard: Introduce generic relocation feature Simon Glass
2011-11-21 23:57 ` [U-Boot] [RFC PATCH 1/7] reboard: define CONFIG_SYS_LEGACY_BOARD everywhere Simon Glass
2011-11-29 3:11 ` Mike Frysinger
2011-11-29 20:08 ` Simon Glass
2011-11-29 21:40 ` Mike Frysinger
2011-11-29 22:09 ` Simon Glass
2011-11-29 23:19 ` Mike Frysinger
2011-11-29 23:40 ` Simon Glass
2011-12-07 8:15 ` Albert ARIBAUD
2011-12-07 16:28 ` Simon Glass
2011-12-05 6:42 ` Aneesh V
2011-11-21 23:57 ` [U-Boot] [RFC PATCH 2/7] reboard: Add generic link symbols Simon Glass
2011-11-29 2:59 ` Mike Frysinger
2011-12-07 22:37 ` Simon Glass
2011-11-21 23:57 ` [U-Boot] [RFC PATCH 3/7] reboard: Add generic relocation feature Simon Glass
2011-11-29 3:07 ` Mike Frysinger
2011-11-29 22:15 ` Simon Glass
2011-11-29 23:00 ` Graeme Russ
2011-11-29 23:20 ` Mike Frysinger
2011-11-29 23:41 ` Simon Glass
2011-11-29 23:49 ` Graeme Russ
2011-11-30 2:58 ` Mike Frysinger
2011-12-07 7:38 ` Albert ARIBAUD
2011-12-08 0:35 ` Mike Frysinger
2011-12-09 3:36 ` Simon Glass
2011-12-07 22:45 ` Simon Glass
2011-12-07 22:54 ` Graeme Russ
2011-12-07 22:55 ` Simon Glass
2011-11-21 23:57 ` [U-Boot] [RFC PATCH 4/7] reboard: arm: Add relocation function Simon Glass
2011-11-21 23:57 ` [U-Boot] [RFC PATCH 5/7] reboard: arm: Add processor function library Simon Glass
2011-11-29 3:12 ` Mike Frysinger
2011-12-07 7:44 ` Albert ARIBAUD
2011-12-07 16:24 ` Simon Glass
2011-11-21 23:57 ` [U-Boot] [RFC PATCH 6/7] reboard: arm: Move over to generic relocation Simon Glass
2011-11-29 3:14 ` Mike Frysinger
2011-12-09 3:41 ` Simon Glass
2011-11-21 23:58 ` [U-Boot] [RFC PATCH 7/7] reboard: arm: Remove unused code in start.S Simon Glass
2011-11-29 3:15 ` Mike Frysinger [this message]
2011-12-09 3:42 ` Simon Glass
2011-11-28 23:45 ` [U-Boot] [RFC PATCH 0/7] reboard: Introduce generic relocation feature Tom Rini
2011-12-07 1:56 ` Simon Glass
2011-12-07 2:56 ` Graeme Russ
2011-12-07 3:25 ` Simon Glass
2011-12-07 3:36 ` Graeme Russ
2011-12-07 23:29 ` Simon Glass
2011-12-07 8:10 ` Albert ARIBAUD
2011-12-09 3:34 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111282215.39824.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox