public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@avionic-design.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: Implement card detection.
Date: Tue, 29 Nov 2011 14:42:30 +0100	[thread overview]
Message-ID: <20111129134230.GA8002@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <CAKWjMd50Rtc1rrGxbMMBW3pCisWz8D06L_beOcBL9y3yWKZnww@mail.gmail.com>

* Andy Fleming wrote:
> On Tue, Nov 29, 2011 at 1:02 AM, Thierry Reding
> <thierry.reding@avionic-design.de> wrote:
> > * Andy Fleming wrote:
> > [...]
> >> Well, while this isn't the case in any systems I know of now, it is
> >> quite possible for there to be more than one *type* of SD/MMC
> >> controller on an SoC, and there's always the possibility that an SoC
> >> provides a non-controller-specific card-detect mechanism. The idea is
> >> that, lacking a board-specific card-detect mechanism, the SoC might be
> >> able to direct the query to the right place.
> >>
> >> But I'm talking very theoretically, here. I wouldn't object to a
> >> mechanism that was just:
> >>
> >> cd = board_mmc_getcd(mmc);
> >>
> >> if (cd < 0 && mmc->getcd)
> >> ? ?cd = mmc->getcd(mmc);
> >>
> >> If we ever ran into a case where an SoC had better knowledge than the
> >> driver, then it's easy to fix the code.
> >
> > That makes sense. The code can always be extended when new hardware requires
> > it. No need to over-engineer at this point.
> >
> > Do you want me to prepare a patch or should we rather wait for some more
> > input from others?
> 
> I'll happily take a patch. I may wait to apply it, but probably, as
> the merge window is *long* closed, so it won't get pulled into
> mainline until mid-December (I'll apply it to my -next branch).

Okay. I may not get to it until later this week anyway.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111129/4e1f0c9c/attachment.pgp>

      reply	other threads:[~2011-11-29 13:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-17 11:51 [U-Boot] [PATCH] mmc: Implement card detection Thierry Reding
2011-11-22 18:13 ` Thierry Reding
2011-11-26  0:40 ` Andy Fleming
2011-11-28 17:47   ` Thierry Reding
2011-11-28 19:20     ` Andy Fleming
2011-11-29  7:02       ` Thierry Reding
2011-11-29 13:39         ` Andy Fleming
2011-11-29 13:42           ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111129134230.GA8002@avionic-0098.adnet.avionic-design.de \
    --to=thierry.reding@avionic-design.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox