* [U-Boot] [PATCH] m68k: fix ambiguous bit testing
@ 2011-10-15 20:10 Mike Frysinger
2011-12-01 21:27 ` Anatolij Gustschin
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2011-10-15 20:10 UTC (permalink / raw)
To: u-boot
Building for some m68k boards results in the warning:
cpu_init.c: In function 'cpu_init_f':
cpu_init.c:287: warning: suggest parentheses around
operand of '!' or change '&' to '&&' or '!' to '~'
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
arch/m68k/cpu/mcf52x2/cpu_init.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/m68k/cpu/mcf52x2/cpu_init.c b/arch/m68k/cpu/mcf52x2/cpu_init.c
index 170bbfc..a98a926 100644
--- a/arch/m68k/cpu/mcf52x2/cpu_init.c
+++ b/arch/m68k/cpu/mcf52x2/cpu_init.c
@@ -284,7 +284,7 @@ void cpu_init_f(void)
mbar_writeLong(MCF_FMPLL_SYNCR,
MCF_FMPLL_SYNCR_MFD(0) | MCF_FMPLL_SYNCR_RFD(0));
#endif
- while (!mbar_readByte(MCF_FMPLL_SYNSR) & MCF_FMPLL_SYNSR_LOCK) ;
+ while (!(mbar_readByte(MCF_FMPLL_SYNSR) & MCF_FMPLL_SYNSR_LOCK)) ;
}
/*
--
1.7.6.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] m68k: fix ambiguous bit testing
2011-10-15 20:10 [U-Boot] [PATCH] m68k: fix ambiguous bit testing Mike Frysinger
@ 2011-12-01 21:27 ` Anatolij Gustschin
0 siblings, 0 replies; 2+ messages in thread
From: Anatolij Gustschin @ 2011-12-01 21:27 UTC (permalink / raw)
To: u-boot
On Sat, 15 Oct 2011 16:10:42 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> Building for some m68k boards results in the warning:
>
> cpu_init.c: In function 'cpu_init_f':
> cpu_init.c:287: warning: suggest parentheses around
> operand of '!' or change '&' to '&&' or '!' to '~'
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> arch/m68k/cpu/mcf52x2/cpu_init.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied to u-boot-staging/agust at denx.de. Thanks!
Anatolij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-01 21:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-15 20:10 [U-Boot] [PATCH] m68k: fix ambiguous bit testing Mike Frysinger
2011-12-01 21:27 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox