From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] menu.c: use puts() instead of printf() where possible
Date: Thu, 01 Dec 2011 23:50:32 +0100 [thread overview]
Message-ID: <20111201225032.CB1A51828FD3@gemini.denx.de> (raw)
In-Reply-To: <201111281810.03260.vapier@gentoo.org>
Dear Mike Frysinger,
In message <201111281810.03260.vapier@gentoo.org> you wrote:
>
> On Monday 28 November 2011 14:24:49 Wolfgang Denk wrote:
> > common/menu.c used printf() in a number of places to print user
> > provided, constant strings (like the "title" string). printf() is
> > dangerous here for example in case the user unwittingly embeds some
> > '%' caracters that printf() would interpret as formatting and then
> > pick up random arguments. Use puts() instead.
>
> i'm not seeing this problem based on your patch below ...
Yes, you are right. I was incorrectly extrapolating from another
issue fixed elsewhere.
> > - printf("^C\n");
> > + puts("^C\n");
>
> this change makes sense, but not for any of the reasons cited in the
> changelog; this looks like a simple optimization ...
True. But d*mn, I have messed this up, and it sneaked into the master
branch already.
Sorry...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If there was anything that depressed him more than his own cynicism,
it was that quite often it still wasn't as cynical as real life.
- Terry Pratchett, _Guards! Guards!_
prev parent reply other threads:[~2011-12-01 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 19:24 [U-Boot] [PATCH] menu.c: use puts() instead of printf() where possible Wolfgang Denk
2011-11-28 23:10 ` Mike Frysinger
2011-12-01 22:50 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201225032.CB1A51828FD3@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox