From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 1 Dec 2011 23:14:24 +0100 Subject: [U-Boot] [PATCH 10/14] board/mpl/common/flash.c: Fix GCC 4.6 build warning In-Reply-To: <1322641077-829-11-git-send-email-wd@denx.de> References: <1322641077-829-1-git-send-email-wd@denx.de> <1322641077-829-11-git-send-email-wd@denx.de> Message-ID: <201112012314.25106.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > Fix: > ../common/flash.c: In function 'flash_init': > ../common/flash.c:160:16: warning: variable 'size_b1' set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Wolfgang Denk > Cc: Denis Peter > --- > ERROR: space required after that ',' (ctx:VxV) > #26: FILE: board/mpl/common/flash.c:160: > + unsigned long flashcr,size_reg; > ^ > > total: 1 errors, 0 warnings, 15 lines checked > > NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX > MULTISTATEMENT_MACRO_USE_DO_WHILE > > Error ignored. No further cleanup attempted. > > board/mpl/common/flash.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/board/mpl/common/flash.c b/board/mpl/common/flash.c > index 81d7271..d5b63c0 100644 > --- a/board/mpl/common/flash.c > +++ b/board/mpl/common/flash.c > @@ -157,7 +157,7 @@ unsigned long flash_init (void) > int i; > > #if !defined(CONFIG_PATI) > - unsigned long size_b1,flashcr,size_reg; > + unsigned long flashcr,size_reg; Can you please add space after the comma (", ") ? Thank you. > int mode; > extern char version_string; > char *p = &version_string; > @@ -197,7 +197,6 @@ unsigned long flash_init (void) > #if !defined(CONFIG_PATI) > /* protect reset vector */ > flash_info[0].protect[flash_info[0].sector_count-1] = 1; > - size_b1 = 0 ; > flash_info[0].size = size_b0; > /* set up flash cs according to the size */ > size_reg=(flash_info[0].size >>20); Otherwise, logic looks OK Acked-by: Marek Vasut