public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tegra2: Use new GPIO APIs in gpio_config_uart()
Date: Fri, 2 Dec 2011 00:08:55 +0100	[thread overview]
Message-ID: <20111202000855.110a1102@wker> (raw)
In-Reply-To: <1317941542-19690-1-git-send-email-swarren@nvidia.com>

Hi Stephen,

On Thu,  6 Oct 2011 16:52:22 -0600
Stephen Warren <swarren@nvidia.com> wrote:

> ... rather than open-coding the register accesses.
> 
> However, gpio_request() typically stores the "label" parameter in a global
> data structure. This causes problems when called from gpio_config_uart(),
> since the code is running before relocation. To solve this, pass a NULL
> string to gpio_request(), and modify gpio_request() not to touch the string
> if it's NULL.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> I tested this on Seaboard. With the code in the patch below, the UART works.
> If I comment out the body of gpio_config_uart_seaboard(), the UART does not
> work.
> 
> This patch should work with ToT U-Boot, but the context relies on the rename
> of gpio_config_uart() to gpio_config_uart_seaboard() contained in:
> http://patchwork.ozlabs.org/patch/118144/
> 
>  board/nvidia/seaboard/seaboard.c |   18 ++----------------
>  drivers/gpio/tegra2_gpio.c       |    6 ++++--
>  2 files changed, 6 insertions(+), 18 deletions(-)

This patch doesn't apply cleanly. There were a lot of tegra2 patches,
so I'm not sure if it is not superseded by some newer patches. Can you
please check and if the patch is needed, then re-base and resubmit.
Thanks!

Anatolij

  parent reply	other threads:[~2011-12-01 23:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-06 22:52 [U-Boot] [PATCH] tegra2: Use new GPIO APIs in gpio_config_uart() Stephen Warren
2011-10-12  0:07 ` Simon Glass
2011-11-15 22:07   ` Stephen Warren
2011-12-01 23:08 ` Anatolij Gustschin [this message]
2011-12-01 23:30   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111202000855.110a1102@wker \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox