From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sat, 3 Dec 2011 04:19:53 -0500 Subject: [U-Boot] [PATCH] MAKEALL: Add -l option to only list build targets In-Reply-To: <201112030923.28183.marek.vasut@gmail.com> References: <1322897523-6663-1-git-send-email-marek.vasut@gmail.com> <201112030257.22221.vapier@gentoo.org> <201112030923.28183.marek.vasut@gmail.com> Message-ID: <201112030419.53711.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 03 December 2011 03:23:28 Marek Vasut wrote: > > On Saturday 03 December 2011 02:32:03 Marek Vasut wrote: > > > + if [ "$ONLY_LIST" == 'y' ] ; then return ; fi > > > > [ "$ONLY_LIST" = "y" ] && return > > I prefer to be explicit. my version is "explicit" as well the point was more that if statements shouldn't be one-liners like that. if you want to keep it, then unwrap the block. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: