From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MAKEALL: Add -l option to only list build targets
Date: Sat, 3 Dec 2011 12:03:50 -0500 [thread overview]
Message-ID: <201112031203.51586.vapier@gentoo.org> (raw)
In-Reply-To: <201112031036.32805.marek.vasut@gmail.com>
On Saturday 03 December 2011 04:36:32 Marek Vasut wrote:
> > On Saturday 03 December 2011 03:23:28 Marek Vasut wrote:
> > > > On Saturday 03 December 2011 02:32:03 Marek Vasut wrote:
> > > > > + if [ "$ONLY_LIST" == 'y' ] ; then return ; fi
> > > >
> > > > [ "$ONLY_LIST" = "y" ] && return
> > >
> > > I prefer to be explicit.
> >
> > my version is "explicit" as well
> >
> > the point was more that if statements shouldn't be one-liners like that.
> > if you want to keep it, then unwrap the block.
>
> Is there any such rule?
i don't think we have a style guide for shell scripts, but what you're
proposing doesn't show up anywhere in the current tree. and it's ugly :P.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111203/ba2e5bb3/attachment.pgp>
next prev parent reply other threads:[~2011-12-03 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-03 7:32 [U-Boot] [PATCH] MAKEALL: Add -l option to only list build targets Marek Vasut
2011-12-03 7:57 ` Mike Frysinger
2011-12-03 8:23 ` Marek Vasut
2011-12-03 9:19 ` Mike Frysinger
2011-12-03 9:36 ` Marek Vasut
2011-12-03 17:03 ` Mike Frysinger [this message]
2011-12-04 2:44 ` Qinglin Ye
2011-12-04 11:32 ` Marek Vasut
2011-12-12 5:49 ` Mike Frysinger
2011-12-03 16:06 ` Kumar Gala
2011-12-03 17:02 ` Marek Vasut
2011-12-06 21:14 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112031203.51586.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox