public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 9/9] arch/arm/include/asm/arch-omap5/clocks.h: Fix GCC 4.2 warnings
Date: Sun, 4 Dec 2011 12:30:40 +0100	[thread overview]
Message-ID: <201112041230.40611.marek.vasut@gmail.com> (raw)
In-Reply-To: <1322930775-4767-9-git-send-email-agust@denx.de>

> Fix:
> clocks.c: In function 'setup_post_dividers':
> clocks.c:175: warning: comparison is always true due to limited range of
> data type
> clocks.c:177: warning: comparison is always true due to limited range of
> data type
> clocks.c:179: warning: comparison is always true due to limited range of
> data type
> clocks.c:181: warning: comparison is always true due to limited range of
> data type
> clocks.c:183: warning: comparison is always true due to limited range of
> data type
> clocks.c:185: warning: comparison is always true due to limited range of
> data type
> clocks.c:187: warning: comparison is always true due to limited range of
> data type
> clocks.c:189: warning: comparison is always true due to limited range of
> data type
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: sricharan <r.sricharan@ti.com>
> Cc: Tom Rini <trini@ti.com>
> ---
> Some notes:
> 
>  - GCC v4.5.1 didn't warn here
>  - GCC v4.6.1 seems to have a bug and can't compile this code:
>    clocks.c: In function 'enable_non_essential_clocks':
>    clocks.c:349:13: internal compiler error: in decode_addr_const, at
> varasm.c:2632
> 
>  arch/arm/include/asm/arch-omap5/clocks.h |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-omap5/clocks.h
> b/arch/arm/include/asm/arch-omap5/clocks.h index fa99f65..d0e6dd6 100644
> --- a/arch/arm/include/asm/arch-omap5/clocks.h
> +++ b/arch/arm/include/asm/arch-omap5/clocks.h
> @@ -686,14 +686,14 @@ struct dpll_regs {
>  struct dpll_params {
>  	u32 m;
>  	u32 n;
> -	u8 m2;
> -	u8 m3;
> -	u8 h11;
> -	u8 h12;
> -	u8 h13;
> -	u8 h14;
> -	u8 h22;
> -	u8 h23;
> +	s8 m2;
> +	s8 m3;
> +	s8 h11;
> +	s8 h12;
> +	s8 h13;
> +	s8 h14;
> +	s8 h22;
> +	s8 h23;
>  };
> 
>  extern struct omap5_prcm_regs *const prcm;

Make clock registers a signed type? whoa

  reply	other threads:[~2011-12-04 11:30 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-03 16:46 [U-Boot] [PATCH 1/9] common/menu.c: Fix build warning Anatolij Gustschin
2011-12-03 16:46 ` [U-Boot] [PATCH 2/9] drivers/mtd/nand/nand_spl_simple.c: Fix GCC 4.6 warnings Anatolij Gustschin
2011-12-04  9:07   ` Heiko Schocher
2011-12-04 11:24   ` Marek Vasut
2011-12-07 22:10   ` Scott Wood
2011-12-03 16:46 ` [U-Boot] [PATCH 3/9] drivers/mtd/nand/nand_spl_load.c: Fix GCC 4.6 warning Anatolij Gustschin
2011-12-04  9:15   ` Heiko Schocher
2011-12-04 11:24   ` Marek Vasut
2011-12-07 22:11   ` Scott Wood
2011-12-03 16:46 ` [U-Boot] [PATCH 4/9] drivers/usb/musb/musb_udc.c: " Anatolij Gustschin
2011-12-04 11:10   ` Remy Bohmer
2011-12-04 11:25   ` Marek Vasut
2011-12-09  9:36   ` Wolfgang Denk
2011-12-03 16:46 ` [U-Boot] [PATCH 5/9] drivers/usb/gadget/core.c: " Anatolij Gustschin
2011-12-04 11:06   ` Remy Bohmer
2011-12-04 11:27   ` Marek Vasut
2011-12-09  9:37   ` Wolfgang Denk
2011-12-03 16:46 ` [U-Boot] [PATCH 6/9] drivers/usb/gadget/ep0.c: " Anatolij Gustschin
2011-12-04 11:11   ` Remy Bohmer
2011-12-04 11:28   ` Marek Vasut
2011-12-09  9:37   ` Wolfgang Denk
2011-12-03 16:46 ` [U-Boot] [PATCH 7/9] arch/arm/cpu/armv7/omap-common/spl.c: Fix GCC 4.2 warnings Anatolij Gustschin
2011-12-04 11:28   ` Marek Vasut
2011-12-05 15:04     ` Tom Rini
2011-12-03 16:46 ` [U-Boot] [PATCH 8/9] arch/arm/cpu/armv7/omap-common/clocks-common.c: Fix GCC 4.6 warnings Anatolij Gustschin
2011-12-04 11:29   ` Marek Vasut
2011-12-05 15:02   ` Tom Rini
2011-12-05 16:32     ` Anatolij Gustschin
2011-12-05 17:11       ` Tom Rini
2011-12-03 16:46 ` [U-Boot] [PATCH 9/9] arch/arm/include/asm/arch-omap5/clocks.h: Fix GCC 4.2 warnings Anatolij Gustschin
2011-12-04 11:30   ` Marek Vasut [this message]
2011-12-04 13:59     ` Anatolij Gustschin
2011-12-05 15:08       ` Tom Rini
2011-12-06  5:52         ` R, Sricharan
2011-12-04  9:17 ` [U-Boot] [PATCH 1/9] common/menu.c: Fix build warning Heiko Schocher
2011-12-04 11:27 ` Marek Vasut
2011-12-04 11:49   ` Anatolij Gustschin
2011-12-05 22:26 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112041230.40611.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox