From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 4 Dec 2011 12:30:40 +0100 Subject: [U-Boot] [PATCH 9/9] arch/arm/include/asm/arch-omap5/clocks.h: Fix GCC 4.2 warnings In-Reply-To: <1322930775-4767-9-git-send-email-agust@denx.de> References: <1322930775-4767-1-git-send-email-agust@denx.de> <1322930775-4767-9-git-send-email-agust@denx.de> Message-ID: <201112041230.40611.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > Fix: > clocks.c: In function 'setup_post_dividers': > clocks.c:175: warning: comparison is always true due to limited range of > data type > clocks.c:177: warning: comparison is always true due to limited range of > data type > clocks.c:179: warning: comparison is always true due to limited range of > data type > clocks.c:181: warning: comparison is always true due to limited range of > data type > clocks.c:183: warning: comparison is always true due to limited range of > data type > clocks.c:185: warning: comparison is always true due to limited range of > data type > clocks.c:187: warning: comparison is always true due to limited range of > data type > clocks.c:189: warning: comparison is always true due to limited range of > data type > > Signed-off-by: Anatolij Gustschin > Cc: sricharan > Cc: Tom Rini > --- > Some notes: > > - GCC v4.5.1 didn't warn here > - GCC v4.6.1 seems to have a bug and can't compile this code: > clocks.c: In function 'enable_non_essential_clocks': > clocks.c:349:13: internal compiler error: in decode_addr_const, at > varasm.c:2632 > > arch/arm/include/asm/arch-omap5/clocks.h | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/include/asm/arch-omap5/clocks.h > b/arch/arm/include/asm/arch-omap5/clocks.h index fa99f65..d0e6dd6 100644 > --- a/arch/arm/include/asm/arch-omap5/clocks.h > +++ b/arch/arm/include/asm/arch-omap5/clocks.h > @@ -686,14 +686,14 @@ struct dpll_regs { > struct dpll_params { > u32 m; > u32 n; > - u8 m2; > - u8 m3; > - u8 h11; > - u8 h12; > - u8 h13; > - u8 h14; > - u8 h22; > - u8 h23; > + s8 m2; > + s8 m3; > + s8 h11; > + s8 h12; > + s8 h13; > + s8 h14; > + s8 h22; > + s8 h23; > }; > > extern struct omap5_prcm_regs *const prcm; Make clock registers a signed type? whoa