From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 7 Dec 2011 22:45:57 +0100 Subject: [U-Boot] [PATCH v2] ne2000: Convert to new net-multi model, fixes build of three boards In-Reply-To: <1319144219-15731-1-git-send-email-bernhard.kaindl@gmx.net> References: <201110171829.33368.vapier@gentoo.org> <1319144219-15731-1-git-send-email-bernhard.kaindl@gmx.net> Message-ID: <201112072245.58008.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > This fixes the build of the two sh boards shmin and r7780mp and qemu-mips > which currently fail to build due to dropped pre-CONFIG_NET_MULTI code. > > This v2 patch minimizes the number of lines in the diff for easy review > and to eliminate any possible accidential changes resulting from moving > lines of code in the file. This also makes the register function very easy. > > Any cleanups and improvements are intentionally deferred to follow-up > patches to keep this patch as simple and as easy to review as possible. > > A new driver register function, ne2k_register() calls the existing > one-time setup part of the old init function and calls eth_register(). > > Changes to shmin, r7780mp and qemu-mips: > - Call the new ne2k_register() from board_eth_init() of the boards. > > - Tested using qemu-mips board, > - Tested the two renesas / sh boards r7780mp and shmin to compile again, > and should work. > > checkpatch-clean when "--ignore VOLATILE" is added to .checkpatch.conf, > and no warnings introduced in none of the three boards using this driver. > > Signed-off-by: Bernhard Kaindl > --- > board/qemu-mips/qemu-mips.c | 6 ++ > board/renesas/r7780mp/r7780mp.c | 3 +- > board/shmin/shmin.c | 6 ++ > drivers/net/ne2000_base.c | 99 > ++++++++++++++++++++++++++++----------- include/netdev.h | > 1 + > 5 files changed, 86 insertions(+), 29 deletions(-) > I think this patch is absolutelly essential to have in .12 release. I'll test it now and ev. rebase and resubmit. Bernhard, you're ok with me doing minor fixes? M