[U-Boot] [PATCH v3 1/2] net: add Calxeda xgmac driver

Rob Herring
2011-12-20T23:12:59Z

Wolfgang,

On 12/20/2011 05:09 PM, Wolfgang Denk wrote:
> Dear Rob Herring,
>
> In message <4EF11209.5050102@gmail.com> you wrote:
>>
>>> Are there going to be any users for this driver?
>>
>> Yes. Patch 2/2 adds support to Calxeda Highbank.
>
> I saw this myself 5 seconds later, but my "send" button has no "undo"
> function ;-) Sorry...
>
>>> Checkpatch says:
>>>
>>> WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
>>> #461: FILE: drivers/net/calxedaxgmac.c:317:
>>> +} __attribute__((aligned(32)));
>>>
>>> Is there any special reason not to change this?
>>
>> I thought it was a false positive because I didn't find any other users
>> of __aligned().
>
> I think we should change this. [I can do this when applying, if you
> like.]
>

Agreed. If you're applying, I like. :)

Thanks,
Rob