From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 02/19] usbdev.c: Fix GCC 4.6 build warnings
Date: Fri, 9 Dec 2011 10:44:03 +0100 [thread overview]
Message-ID: <201112091044.03681.sr@denx.de> (raw)
In-Reply-To: <20111209093101.A9A6F1EFED8@gemini.denx.de>
Hi Wolfgang,
On Friday 09 December 2011 10:31:01 Wolfgang Denk wrote:
> In message <1321380112-6210-1-git-send-email-sr@denx.de> you wrote:
> > Fix:
> > usbdev.c: In function 'process_endpoints':
> > usbdev.c:29:12: warning: variable 'temp1' set but not used
> > [-Wunused-but-set-variable] usbdev.c:29:6: warning: variable 'temp' set
> > but not used [-Wunused-but-set-variable]
> >
> > Signed-off-by: Stefan Roese <sr@denx.de>
>
> ...
>
> > @@ -44,8 +43,6 @@ void process_endpoints(unsigned short usb2d0_intrin)
> >
> > /*copy packet */
> > setup_packet_pt[0] = *(unsigned int *)USB2D0_FIFO_0;
> > setup_packet_pt[1] = *(unsigned int *)USB2D0_FIFO_0;
> >
> > - temp = *(unsigned int *)USB2D0_FIFO_0;
> > - temp1 = *(unsigned int *)USB2D0_FIFO_0;
>
> It seems we agree that these reads from the FIFO registers may
> actually be important for proper operation. Are you planning to
> submit an updated, improved patch?
This file has been removed with patch ce2acd371c4eee36e55d706a181361c25ebfe160
already in mainline.
Best regards,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2011-12-09 9:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 18:01 [U-Boot] [PATCH 02/19] usbdev.c: Fix GCC 4.6 build warnings Stefan Roese
2011-11-15 23:01 ` Mike Frysinger
2011-11-16 2:26 ` Marek Vasut
2011-12-09 9:31 ` Wolfgang Denk
2011-12-09 9:44 ` Stefan Roese [this message]
2011-12-09 11:18 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112091044.03681.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox