[U-Boot] [PATCH 1/2] NET: NE2000: Cleanup IO accessors

Marek Vasut
2011-12-12T10:17:49Z

> On Sunday 11 December 2011 08:42:07 Marek Vasut wrote:
> > > On Saturday 10 December 2011 20:09:30 Marek Vasut wrote:
> > > > Introduce ne2k_register_io(in, out), which allows user to supply two
> > > > functions. One for reading data from the card, the other for writing
> > > > data to the card. Then introduce drivers' private data, which carry
> > > > pointers to these functions and are passed throughout the driver.
> > >
> > > where are the users of this new API ? as it stands, i just see bloat.
> > > every register access is now an indirect function call ? what's the
> > > point
> >
> > Go to ... drivers/net/ax88796.h ... and check how it's done now. It's
> > just wrong. Now for .03 release I have pxa3xx support ready which uses
> > just this chip and adding more sh^Htuff to that fill would be even worse
> > bloat.
>
> i agree, that code is terrible. however, those code paths can be trivially
> merged without the proposed bloat yours brings in.

So what's your suggested awesome clean solution?

> further, that code base
> isn't even used by the ne2000 driver.

What are you talking about, did you even bother to look?
>
> so again, the question stands: what exactly do you need to do different ?
> looks to me like the DP_* macros should get punted in favor of io.h
> accessors, and the register offsets rewritten into C structs.

Sure, but not every hardware accesses the registers the same way. So I'm open
for your suggestions on how to do it properly, apparently you have much better
idea up your sleeve.

M