From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 11 Dec 2011 14:42:07 +0100 Subject: [U-Boot] [PATCH 1/2] NET: NE2000: Cleanup IO accessors In-Reply-To: <201112110224.52449.vapier@gentoo.org> References: <1323565772-4498-1-git-send-email-marek.vasut@gmail.com> <201112110224.52449.vapier@gentoo.org> Message-ID: <201112111442.08303.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > On Saturday 10 December 2011 20:09:30 Marek Vasut wrote: > > Introduce ne2k_register_io(in, out), which allows user to supply two > > functions. One for reading data from the card, the other for writing data > > to the card. Then introduce drivers' private data, which carry pointers > > to these functions and are passed throughout the driver. > > where are the users of this new API ? as it stands, i just see bloat. > every register access is now an indirect function call ? what's the point Go to ... drivers/net/ax88796.h ... and check how it's done now. It's just wrong. Now for .03 release I have pxa3xx support ready which uses just this chip and adding more sh^Htuff to that fill would be even worse bloat. M