public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] PXA: Fix building for lubbock board
Date: Mon, 12 Dec 2011 16:23:37 +0100	[thread overview]
Message-ID: <201112121623.37192.marek.vasut@gmail.com> (raw)
In-Reply-To: <1323702929-27781-1-git-send-email-agust@denx.de>

> Fix:
> drivers/mmc/libmmc.o: In function `mmc_legacy_init':
> drivers/mmc/pxa_mmc.c:565: undefined reference to `set_GPIO_mode'
> drivers/mmc/pxa_mmc.c:566: undefined reference to `set_GPIO_mode'
> 
> Re-add set_GPIO_mode() which has been removed by commit
> d10237d275300562bbfecbbe2f59a97cfb9dc180 (PXA: Separate
> PXA2xx CPU init).
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> ---
>  arch/arm/cpu/pxa/pxa2xx.c |   25 +++++++++++++++++++++++++
>  1 files changed, 25 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/cpu/pxa/pxa2xx.c b/arch/arm/cpu/pxa/pxa2xx.c
> index 09e8177..42fb4fc 100644
> --- a/arch/arm/cpu/pxa/pxa2xx.c
> +++ b/arch/arm/cpu/pxa/pxa2xx.c
> @@ -299,3 +299,28 @@ void reset_cpu(ulong ignored)
>  	for (;;)
>  		;
>  }
> +
> +#ifndef CONFIG_CPU_MONAHANS
> +void set_GPIO_mode(int gpio_mode)
> +{
> +	int gpio = gpio_mode & GPIO_MD_MASK_NR;
> +	int fn = (gpio_mode & GPIO_MD_MASK_FN) >> 8;
> +	int val;
> +
> +	/* This below changes direction setting of GPIO "gpio" */
> +	val = readl(GPDR(gpio));
> +
> +	if (gpio_mode & GPIO_MD_MASK_DIR)
> +		val |= GPIO_bit(gpio);
> +	else
> +		val &= ~GPIO_bit(gpio);
> +
> +	writel(val, GPDR(gpio));
> +
> +	/* This below updates only AF of GPIO "gpio" */
> +	val = readl(GAFR(gpio));
> +	val &= ~(0x3 << (((gpio) & 0xf) * 2));
> +	val |= fn << (((gpio) & 0xf) * 2);
> +	writel(val, GAFR(gpio));
> +}
> +#endif /* CONFIG_CPU_MONAHANS */

NAK, this is insane and should die. I'll submit a proper patch.

M

  reply	other threads:[~2011-12-12 15:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 15:15 [U-Boot] [PATCH] PXA: Fix building for lubbock board Anatolij Gustschin
2011-12-12 15:23 ` Marek Vasut [this message]
2011-12-12 15:34 ` [U-Boot] [PATCH] PXA: Kill last remnants of set_GPIO_mode function Marek Vasut
2011-12-19 15:57   ` Anatolij Gustschin
2011-12-19 16:15     ` Albert ARIBAUD
2011-12-19 16:24       ` Anatolij Gustschin
2011-12-19 16:25       ` Marek Vasut
2011-12-19 16:33         ` Wolfgang Denk
2011-12-19 16:49           ` Albert ARIBAUD
2011-12-19 17:25             ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112121623.37192.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox