From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fs/fat/fat.c: fix warning: 'part_size' defined but not used
Date: Tue, 13 Dec 2011 12:03:35 +0100 [thread overview]
Message-ID: <20111213110335.15DAE183AA3D@gemini.denx.de> (raw)
In-Reply-To: <20111213095358.5601b9ce@wker>
Dear Anatolij Gustschin,
In message <20111213095358.5601b9ce@wker> you wrote:
>
> The FAT write support as submitted and included seems to be broken.
> The removed variable is referenced in fs/fat/fat_write.c, but in
> fs/fat/fat.c it is declared as static. This issue didn't show up
> because no board config file in mainline defines CONFIG_FAT_WRITE.
It's not only that. It appears that this code is also not hooked upo
to any command a user could call. At least, I cannot see anything
like that in common/cmd_fat.c or so...
> @ Donggeun Kim
> Could you please submit a patch fixing this?
I guess this needs more fixing...
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If you own a machine, you are in turn owned by it, and spend your
time serving it..." - Marion Zimmer Bradley, _The Forbidden Tower_
next prev parent reply other threads:[~2011-12-13 11:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 7:15 [U-Boot] [PATCH v2] FAT: Add FAT write feature Donggeun Kim
2011-10-26 19:41 ` Wolfgang Denk
2011-10-27 13:48 ` Marek Vasut
2011-10-26 22:45 ` Mike Frysinger
2011-10-27 20:55 ` Wolfgang Denk
2011-10-27 21:08 ` Mike Frysinger
2011-10-27 21:10 ` [U-Boot] [PATCH] fs/fat/fat.c: fix warning: 'part_size' defined but not used Wolfgang Denk
2011-12-13 6:15 ` Aaron Williams
2011-12-13 8:18 ` Wolfgang Denk
2011-12-13 8:53 ` Anatolij Gustschin
2011-12-13 11:03 ` Wolfgang Denk [this message]
2011-12-13 8:37 ` Donggeun Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213110335.15DAE183AA3D@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox