From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 00/18] CHECKPATCH: fpgadata.c cleanup
Date: Wed, 14 Dec 2011 01:37:46 +0100 [thread overview]
Message-ID: <201112140137.46418.marek.vasut@gmail.com> (raw)
In-Reply-To: <CALButCKJ41QfPN_=NAhX7SkVREi+NA0d5i+wL2a0CLGWwzmqTQ@mail.gmail.com>
> Hi Marek,
>
> On Wed, Dec 14, 2011 at 10:49 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > First of the CHECKPATCH series of patches with per-file checkpatch fixes.
> >
> > This series fixes all files fpgadata.c, which contains PPC FPGA
> > firmwares. There are no functional changes, only CHECKPATCH fixes.
> >
> > Marek Vasut (18):
> > CHECKPATCH: ./board/esd/hh405/fpgadata.c
> > CHECKPATCH: ./board/esd/pci405/fpgadata.c
> > CHECKPATCH: ./board/esd/tasreg/fpgadata.c
> > CHECKPATCH: ./board/esd/apc405/fpgadata.c
> > CHECKPATCH: ./board/esd/voh405/fpgadata.c
> > CHECKPATCH: ./board/esd/ash405/fpgadata.c
> > CHECKPATCH: ./board/esd/dasa_sim/fpgadata.c
> > CHECKPATCH: ./board/esd/ar405/fpgadata_xl30.c
> > CHECKPATCH: ./board/esd/ar405/fpgadata.c
> > CHECKPATCH: ./board/esd/plu405/fpgadata.c
> > CHECKPATCH: ./board/esd/wuh405/fpgadata.c
> > CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405.c
> > CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405ab.c
> > CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci4052.c
> > CHECKPATCH: ./board/esd/canbt/fpgadata.c
> > CHECKPATCH: ./board/esd/du405/fpgadata.c
> > CHECKPATCH: ./board/esd/cpciiser4/fpgadata.c
> > CHECKPATCH: ./board/dave/PPChameleonEVB/fpgadata.c
> >
> > board/dave/PPChameleonEVB/fpgadata.c | 2657 ++++---
> > board/esd/apc405/fpgadata.c | 4676 +++++++-----
> > board/esd/ar405/fpgadata.c | 6417 ++++++++++-------
> > board/esd/ar405/fpgadata_xl30.c | 5684 +++++++++-------
> > board/esd/ash405/fpgadata.c | 5814 +++++++++-------
> > board/esd/canbt/fpgadata.c | 942 ++--
> > board/esd/cpci405/fpgadata_cpci405.c | 798 ++-
> > board/esd/cpci405/fpgadata_cpci4052.c | 1785 +++--
> > board/esd/cpci405/fpgadata_cpci405ab.c | 2998 +++++----
> > board/esd/cpciiser4/fpgadata.c | 4825 +++++++------
> > board/esd/dasa_sim/fpgadata.c | 4554 +++++++-----
> > board/esd/du405/fpgadata.c | 1640 +++--
> > board/esd/hh405/fpgadata.c | 5873 +++++++++-------
> > board/esd/pci405/fpgadata.c | 1741 +++--
> > board/esd/plu405/fpgadata.c | 2751 ++++---
> > board/esd/tasreg/fpgadata.c |12439
> > ++++++++++++++++++-------------- board/esd/voh405/fpgadata.c
> > | 4692 +++++++------
> > board/esd/wuh405/fpgadata.c | 4242 +++++++-----
> > 18 files changed, 42586 insertions(+), 31942 deletions(-)
>
> Just looking at the first ones to come through, you've changed them
> from having 16 bytes of data (i.e. one word) per line to 12. I
> personally prefer the 80 line rule being broken in favour of having a
> neat number of bytes per line...
>
> Regards,
>
> Graeme
Hi Graeme,
I can realign them to 8 bytes, but I'd prefer to see them checkpatch comformant.
M
next prev parent reply other threads:[~2011-12-14 0:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 23:49 [U-Boot] [PATCH 00/18] CHECKPATCH: fpgadata.c cleanup Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 01/18] CHECKPATCH: ./board/esd/hh405/fpgadata.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 02/18] CHECKPATCH: ./board/esd/pci405/fpgadata.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 03/18] CHECKPATCH: ./board/esd/tasreg/fpgadata.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 04/18] CHECKPATCH: ./board/esd/apc405/fpgadata.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 05/18] CHECKPATCH: ./board/esd/voh405/fpgadata.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 06/18] CHECKPATCH: ./board/esd/ash405/fpgadata.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 07/18] CHECKPATCH: ./board/esd/dasa_sim/fpgadata.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 08/18] CHECKPATCH: ./board/esd/ar405/fpgadata_xl30.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 09/18] CHECKPATCH: ./board/esd/ar405/fpgadata.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 10/18] CHECKPATCH: ./board/esd/plu405/fpgadata.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 11/18] CHECKPATCH: ./board/esd/wuh405/fpgadata.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 12/18] CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 13/18] CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405ab.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 14/18] CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci4052.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 15/18] CHECKPATCH: ./board/esd/canbt/fpgadata.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 16/18] CHECKPATCH: ./board/esd/du405/fpgadata.c Marek Vasut
2011-12-13 23:49 ` [U-Boot] [PATCH 17/18] CHECKPATCH: ./board/esd/cpciiser4/fpgadata.c Marek Vasut
2011-12-13 23:50 ` [U-Boot] [PATCH 18/18] CHECKPATCH: ./board/dave/PPChameleonEVB/fpgadata.c Marek Vasut
2011-12-13 23:56 ` [U-Boot] [PATCH 00/18] CHECKPATCH: fpgadata.c cleanup Graeme Russ
2011-12-14 0:37 ` Marek Vasut [this message]
2011-12-14 0:47 ` Graeme Russ
2011-12-14 3:06 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112140137.46418.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox