From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 14 Dec 2011 01:37:46 +0100 Subject: [U-Boot] [PATCH 00/18] CHECKPATCH: fpgadata.c cleanup In-Reply-To: References: <1323820200-6850-1-git-send-email-marek.vasut@gmail.com> Message-ID: <201112140137.46418.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > Hi Marek, > > On Wed, Dec 14, 2011 at 10:49 AM, Marek Vasut wrote: > > First of the CHECKPATCH series of patches with per-file checkpatch fixes. > > > > This series fixes all files fpgadata.c, which contains PPC FPGA > > firmwares. There are no functional changes, only CHECKPATCH fixes. > > > > Marek Vasut (18): > > CHECKPATCH: ./board/esd/hh405/fpgadata.c > > CHECKPATCH: ./board/esd/pci405/fpgadata.c > > CHECKPATCH: ./board/esd/tasreg/fpgadata.c > > CHECKPATCH: ./board/esd/apc405/fpgadata.c > > CHECKPATCH: ./board/esd/voh405/fpgadata.c > > CHECKPATCH: ./board/esd/ash405/fpgadata.c > > CHECKPATCH: ./board/esd/dasa_sim/fpgadata.c > > CHECKPATCH: ./board/esd/ar405/fpgadata_xl30.c > > CHECKPATCH: ./board/esd/ar405/fpgadata.c > > CHECKPATCH: ./board/esd/plu405/fpgadata.c > > CHECKPATCH: ./board/esd/wuh405/fpgadata.c > > CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405.c > > CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci405ab.c > > CHECKPATCH: ./board/esd/cpci405/fpgadata_cpci4052.c > > CHECKPATCH: ./board/esd/canbt/fpgadata.c > > CHECKPATCH: ./board/esd/du405/fpgadata.c > > CHECKPATCH: ./board/esd/cpciiser4/fpgadata.c > > CHECKPATCH: ./board/dave/PPChameleonEVB/fpgadata.c > > > > board/dave/PPChameleonEVB/fpgadata.c | 2657 ++++--- > > board/esd/apc405/fpgadata.c | 4676 +++++++----- > > board/esd/ar405/fpgadata.c | 6417 ++++++++++------- > > board/esd/ar405/fpgadata_xl30.c | 5684 +++++++++------- > > board/esd/ash405/fpgadata.c | 5814 +++++++++------- > > board/esd/canbt/fpgadata.c | 942 ++-- > > board/esd/cpci405/fpgadata_cpci405.c | 798 ++- > > board/esd/cpci405/fpgadata_cpci4052.c | 1785 +++-- > > board/esd/cpci405/fpgadata_cpci405ab.c | 2998 +++++---- > > board/esd/cpciiser4/fpgadata.c | 4825 +++++++------ > > board/esd/dasa_sim/fpgadata.c | 4554 +++++++----- > > board/esd/du405/fpgadata.c | 1640 +++-- > > board/esd/hh405/fpgadata.c | 5873 +++++++++------- > > board/esd/pci405/fpgadata.c | 1741 +++-- > > board/esd/plu405/fpgadata.c | 2751 ++++--- > > board/esd/tasreg/fpgadata.c |12439 > > ++++++++++++++++++-------------- board/esd/voh405/fpgadata.c > > | 4692 +++++++------ > > board/esd/wuh405/fpgadata.c | 4242 +++++++----- > > 18 files changed, 42586 insertions(+), 31942 deletions(-) > > Just looking at the first ones to come through, you've changed them > from having 16 bytes of data (i.e. one word) per line to 12. I > personally prefer the 80 line rule being broken in favour of having a > neat number of bytes per line... > > Regards, > > Graeme Hi Graeme, I can realign them to 8 bytes, but I'd prefer to see them checkpatch comformant. M