From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] add missing space
Date: Fri, 16 Dec 2011 13:13:47 +0100 [thread overview]
Message-ID: <20111216131347.7919d4db@wker> (raw)
In-Reply-To: <20111215233215.GB21725@w500.lan>
Hi Luka,
On Fri, 16 Dec 2011 00:32:15 +0100
Luka Perkov <lists@lukaperkov.net> wrote:
> Cosmetic patch for first U-Boot line that gets printed.
>
> Signed-off-by: Luka Perkov <lists@lukaperkov.net>
> ---
> diff --git a/include/version.h b/include/version.h
> index c908bd3..ac5a39a 100644
> --- a/include/version.h
> +++ b/include/version.h
> @@ -35,7 +35,7 @@
> #endif
>
> #define U_BOOT_VERSION_STRING U_BOOT_VERSION " (" U_BOOT_DATE " - " \
> - U_BOOT_TIME ")" CONFIG_IDENT_STRING
> + U_BOOT_TIME ") " CONFIG_IDENT_STRING
This change is not needed I think. Most boards defining
CONFIG_IDENT_STRING use either a string starting with new line or
strings like " something". So this patch will deface version string.
Your CONFIG_IDENT_STRING should be fixed instead.
Thanks,
Anatolij
next prev parent reply other threads:[~2011-12-16 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 23:32 [U-Boot] [PATCH] add missing space Luka Perkov
2011-12-16 12:13 ` Anatolij Gustschin [this message]
2011-12-16 15:59 ` Mike Frysinger
2011-12-16 23:43 ` Luka Perkov
2011-12-16 23:49 ` Mike Frysinger
2011-12-17 16:06 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216131347.7919d4db@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox